From: David Miller <davem@davemloft.net>
To: timur@codeaurora.org
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] [net-next] net: qcom/emac: add ethool support for setting pause parameters
Date: Tue, 07 Feb 2017 13:19:35 -0500 (EST) [thread overview]
Message-ID: <20170207.131935.63339253886860831.davem@davemloft.net> (raw)
In-Reply-To: <1486416892-10927-1-git-send-email-timur@codeaurora.org>
From: Timur Tabi <timur@codeaurora.org>
Date: Mon, 6 Feb 2017 15:34:52 -0600
> To support setting the pause parameters, the driver can no longer just
> mirror the PHY. The set_pauseparam feature allows the driver to
> force the setting in the MAC, regardless of how the PHY is configured.
> This means that we now need to maintain an internal state for pause
> frame support, and so get_pauseparam also needs to be updated.
>
> If the interface is already running when the setting is changed, then
> the interface is reset.
>
> Note that if the MAC is configured to enable RX pause frame support
> (i.e. it transmits pause frames to throttle the other end), but the
> PHY is configured to block those frames, then the feature will not work.
>
> Also some buffer size initialization code into emac_init_adapter(),
> so that it lives with similar code, including the initializtion of
> pause frame support.
>
> Signed-off-by: Timur Tabi <timur@codeaurora.org>
Looks good, applied, thanks Timur.
prev parent reply other threads:[~2017-02-07 18:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-06 21:34 [PATCH] [net-next] net: qcom/emac: add ethool support for setting pause parameters Timur Tabi
2017-02-07 18:19 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170207.131935.63339253886860831.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).