From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] sctp: drop __packed from almost all SCTP structures Date: Tue, 07 Feb 2017 14:11:23 -0500 (EST) Message-ID: <20170207.141123.633919678220393477.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org, vyasevich@gmail.com, nhorman@tuxdriver.com, David.Laight@ACULAB.COM To: marcelo.leitner@gmail.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:55386 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754323AbdBGTU4 (ORCPT ); Tue, 7 Feb 2017 14:20:56 -0500 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Marcelo Ricardo Leitner Date: Tue, 7 Feb 2017 11:37:56 -0200 > __packed is considered harmful as it potentially generates code that > doesn't perform well and its usage should be avoided as much as > possible. > > This patch drops __packed from all SCTP structures except one, which is > sctp_signed_cookie. In there it's required, as per changelog on > commit 9834a2bb4970 ("[SCTP]: Fix sctp_cookie alignment in the packet."). > > After this patch, no alignment changes neither in x86 or x86_64 and > no exceptions were noticed during testing on both archs. > > Code size for SCTP module also didn't change with this patch. > > Cc: David Miller > Cc: David Laight > Signed-off-by: Marcelo Ricardo Leitner Looks great, thanks so much for following through on this! Applied.