From: David Miller <davem@davemloft.net>
To: roopa@cumulusnetworks.com
Cc: nikolay@cumulusnetworks.com, netdev@vger.kernel.org,
bridge@lists.linux-foundation.org, dan.carpenter@oracle.com
Subject: Re: [PATCH net-next] bridge: remove unnecessary check for vtbegin in br_fill_vlan_tinfo_range
Date: Tue, 07 Feb 2017 14:14:30 -0500 (EST) [thread overview]
Message-ID: <20170207.141430.837924902975646212.davem@davemloft.net> (raw)
In-Reply-To: <1486478603-38776-1-git-send-email-roopa@cumulusnetworks.com>
From: Roopa Prabhu <roopa@cumulusnetworks.com>
Date: Tue, 7 Feb 2017 06:43:23 -0800
> From: Roopa Prabhu <roopa@cumulusnetworks.com>
>
> vtbegin should not be NULL in this function, Its already checked by the
> caller.
>
> this should silence the below smatch complaint:
> net/bridge/br_netlink_tunnel.c:144 br_fill_vlan_tinfo_range()
> error: we previously assumed 'vtbegin' could be null (see line 130)
>
> net/bridge/br_netlink_tunnel.c
> 129
> 130 if (vtbegin && vtend && (vtend->vid - vtbegin->vid) > 0) {
> ^^^^^^^
> Check for NULL.
>
> Fixes: efa5356b0d97 ("bridge: per vlan dst_metadata netlink support")
> Reported-By: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Applied.
prev parent reply other threads:[~2017-02-07 19:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 14:43 [PATCH net-next] bridge: remove unnecessary check for vtbegin in br_fill_vlan_tinfo_range Roopa Prabhu via Bridge
2017-02-07 19:14 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170207.141430.837924902975646212.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bridge@lists.linux-foundation.org \
--cc=dan.carpenter@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).