* [PATCH] [net-next] mlxsw: add psample dependency for spectrum
@ 2017-02-06 16:26 Arnd Bergmann
2017-02-06 16:41 ` Yotam Gigi
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Arnd Bergmann @ 2017-02-06 16:26 UTC (permalink / raw)
To: Jiri Pirko, Ido Schimmel
Cc: Arnd Bergmann, David S. Miller, Vadim Pasternak, Elad Raz,
Ivan Vecera, netdev, linux-kernel
When PSAMPLE is a loadable module, spectrum must not be built-in:
drivers/net/built-in.o: In function `mlxsw_sp_rx_listener_sample_func':
spectrum.c:(.text+0xe357e): undefined reference to `psample_sample_packet'
This adds a Kconfig dependency to enforce usable configurations.
Fixes: 98d0f7b9acda ("mlxsw: spectrum: Add packet sample offloading support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/net/ethernet/mellanox/mlxsw/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/mellanox/mlxsw/Kconfig b/drivers/net/ethernet/mellanox/mlxsw/Kconfig
index 76a7574c3c7d..ef23eaedc2ff 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/Kconfig
+++ b/drivers/net/ethernet/mellanox/mlxsw/Kconfig
@@ -73,6 +73,7 @@ config MLXSW_SWITCHX2
config MLXSW_SPECTRUM
tristate "Mellanox Technologies Spectrum support"
depends on MLXSW_CORE && MLXSW_PCI && NET_SWITCHDEV && VLAN_8021Q
+ depends on PSAMPLE || PSAMPLE=n
select PARMAN
default m
---help---
--
2.9.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* RE: [PATCH] [net-next] mlxsw: add psample dependency for spectrum
2017-02-06 16:26 [PATCH] [net-next] mlxsw: add psample dependency for spectrum Arnd Bergmann
@ 2017-02-06 16:41 ` Yotam Gigi
2017-02-07 9:47 ` Jiri Pirko
2017-02-07 16:44 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Yotam Gigi @ 2017-02-06 16:41 UTC (permalink / raw)
To: Arnd Bergmann, Jiri Pirko, Ido Schimmel
Cc: David S. Miller, Vadim Pasternak, Elad Raz, Ivan Vecera,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
>-----Original Message-----
>From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org] On
>Behalf Of Arnd Bergmann
>Sent: Monday, February 06, 2017 6:27 PM
>To: Jiri Pirko <jiri@mellanox.com>; Ido Schimmel <idosch@mellanox.com>
>Cc: Arnd Bergmann <arnd@arndb.de>; David S. Miller <davem@davemloft.net>;
>Vadim Pasternak <vadimp@mellanox.com>; Elad Raz <eladr@mellanox.com>; Ivan
>Vecera <cera@cera.cz>; netdev@vger.kernel.org; linux-kernel@vger.kernel.org
>Subject: [PATCH] [net-next] mlxsw: add psample dependency for spectrum
>
>When PSAMPLE is a loadable module, spectrum must not be built-in:
>
>drivers/net/built-in.o: In function `mlxsw_sp_rx_listener_sample_func':
>spectrum.c:(.text+0xe357e): undefined reference to `psample_sample_packet'
>
>This adds a Kconfig dependency to enforce usable configurations.
>
>Fixes: 98d0f7b9acda ("mlxsw: spectrum: Add packet sample offloading support")
>Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Yotam Gigi <yotamg@mellanox.com>
>---
> drivers/net/ethernet/mellanox/mlxsw/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/net/ethernet/mellanox/mlxsw/Kconfig
>b/drivers/net/ethernet/mellanox/mlxsw/Kconfig
>index 76a7574c3c7d..ef23eaedc2ff 100644
>--- a/drivers/net/ethernet/mellanox/mlxsw/Kconfig
>+++ b/drivers/net/ethernet/mellanox/mlxsw/Kconfig
>@@ -73,6 +73,7 @@ config MLXSW_SWITCHX2
> config MLXSW_SPECTRUM
> tristate "Mellanox Technologies Spectrum support"
> depends on MLXSW_CORE && MLXSW_PCI && NET_SWITCHDEV &&
>VLAN_8021Q
>+ depends on PSAMPLE || PSAMPLE=n
> select PARMAN
> default m
> ---help---
>--
>2.9.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] [net-next] mlxsw: add psample dependency for spectrum
2017-02-06 16:26 [PATCH] [net-next] mlxsw: add psample dependency for spectrum Arnd Bergmann
2017-02-06 16:41 ` Yotam Gigi
@ 2017-02-07 9:47 ` Jiri Pirko
2017-02-07 16:44 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Jiri Pirko @ 2017-02-07 9:47 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Jiri Pirko, Ido Schimmel, David S. Miller, Vadim Pasternak,
Elad Raz, Ivan Vecera, netdev, linux-kernel
Mon, Feb 06, 2017 at 05:26:30PM CET, arnd@arndb.de wrote:
>When PSAMPLE is a loadable module, spectrum must not be built-in:
>
>drivers/net/built-in.o: In function `mlxsw_sp_rx_listener_sample_func':
>spectrum.c:(.text+0xe357e): undefined reference to `psample_sample_packet'
>
>This adds a Kconfig dependency to enforce usable configurations.
>
>Fixes: 98d0f7b9acda ("mlxsw: spectrum: Add packet sample offloading support")
>Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Jiri Pirko <jiri@mellanox.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] [net-next] mlxsw: add psample dependency for spectrum
2017-02-06 16:26 [PATCH] [net-next] mlxsw: add psample dependency for spectrum Arnd Bergmann
2017-02-06 16:41 ` Yotam Gigi
2017-02-07 9:47 ` Jiri Pirko
@ 2017-02-07 16:44 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2017-02-07 16:44 UTC (permalink / raw)
To: arnd; +Cc: jiri, idosch, vadimp, eladr, cera, netdev, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Date: Mon, 6 Feb 2017 17:26:30 +0100
> When PSAMPLE is a loadable module, spectrum must not be built-in:
>
> drivers/net/built-in.o: In function `mlxsw_sp_rx_listener_sample_func':
> spectrum.c:(.text+0xe357e): undefined reference to `psample_sample_packet'
>
> This adds a Kconfig dependency to enforce usable configurations.
>
> Fixes: 98d0f7b9acda ("mlxsw: spectrum: Add packet sample offloading support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-02-07 16:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-06 16:26 [PATCH] [net-next] mlxsw: add psample dependency for spectrum Arnd Bergmann
2017-02-06 16:41 ` Yotam Gigi
2017-02-07 9:47 ` Jiri Pirko
2017-02-07 16:44 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).