From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Igor Pylypiv <igor.pylypiv@gmail.com>
Cc: "David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, netfilter-devel@vger.kernel.org,
coreteam@netfilter.org
Subject: Re: [PATCH] Revert "net: Remove state argument from skb_find_text()"
Date: Tue, 7 Feb 2017 13:36:16 +0100 [thread overview]
Message-ID: <20170207123616.GA2607@salvia> (raw)
In-Reply-To: <1486273710-18457-1-git-send-email-igor.pylypiv@gmail.com>
On Sat, Feb 04, 2017 at 09:48:30PM -0800, Igor Pylypiv wrote:
> This reverts commit 059a2440fd3cf4ec57735db2c0a90401cde84fca.
>
> Textsearch state parameter should be passed by pointer because
> its resulting value is needed for call to textsearch_next().
You're right this renders textsearch_next() useless.
But I remember David took this one time ago because there are no
clients for textsearch_next() in the tree, apart from
textsearch_find().
Am I missing anything?
Thanks.
next prev parent reply other threads:[~2017-02-07 12:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-05 5:48 [PATCH] Revert "net: Remove state argument from skb_find_text()" Igor Pylypiv
2017-02-07 12:36 ` Pablo Neira Ayuso [this message]
2017-02-07 15:53 ` David Miller
2017-02-08 2:45 ` [PATCH] net: fix description of skb_find_text() according to removed functionality Igor Pylypiv
2017-02-08 3:02 ` David Miller
2017-02-08 8:44 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170207123616.GA2607@salvia \
--to=pablo@netfilter.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=igor.pylypiv@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).