From: Stephen Hemminger <stephen@networkplumber.org>
To: David Ahern <dsa@cumulusnetworks.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2] ip route: Make name of protocol 0 consistent
Date: Tue, 7 Feb 2017 14:19:07 -0800 [thread overview]
Message-ID: <20170207141907.175b89a7@xeon-e3> (raw)
In-Reply-To: <5d4b2d3f-300d-2486-c660-b4704c41cacd@cumulusnetworks.com>
On Tue, 7 Feb 2017 14:51:45 -0700
David Ahern <dsa@cumulusnetworks.com> wrote:
> On 2/7/17 2:40 PM, Stephen Hemminger wrote:
> >> Reading the file changes the string in rtnl_rtprot_tab for
> >> RTPROT_UNSPEC. Both string values -- "none" and "unspec" come from
> >> iproute2, so my point is that string is inconsistent within iproute2.
> >
> > Why not change the value in the table rtnl_rtprot_tab to be unspec this would
> > make the command consistent with the value in the header file.
> >
>
> I flipped a coin; it landed on config file.
>
> "none" is the value that has shown up for 13+ years unless a custom
> protocol value is used triggering the 'unspec'. Seems to me a custom
> protocol value is a rare event suggesting conformity to "none" over
> "unspsec". I really don't care what the string is, but it should be
> consistent. If you want 'unspec' I'll change rtnl_rtprot_tab
Agree it was a coin toss, there were two values in iproute2, but the
kernel header file enum value should supersede.
prev parent reply other threads:[~2017-02-07 22:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-02 17:22 [PATCH iproute2] ip route: Make name of protocol 0 consistent David Ahern
2017-02-06 22:01 ` Stephen Hemminger
2017-02-06 23:03 ` David Ahern
2017-02-07 17:00 ` David Ahern
2017-02-07 21:40 ` Stephen Hemminger
2017-02-07 21:51 ` David Ahern
2017-02-07 22:19 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170207141907.175b89a7@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dsa@cumulusnetworks.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).