netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [net-next:master 376/390] drivers/net/ethernet/qualcomm/emac/emac-ethtool.c:155:49-50: Unneeded semicolon
@ 2017-02-07 19:41 kbuild test robot
  2017-02-07 19:42 ` [PATCH] net: qcom/emac: fix semicolon.cocci warnings kbuild test robot
  0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2017-02-07 19:41 UTC (permalink / raw)
  To: Timur Tabi; +Cc: kbuild-all, netdev

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
head:   ca6d4480f87db9d9470d3d7bbe445953fa105e57
commit: b44700e975848a9a569a509244672ff886ec99b3 [376/390] net: qcom/emac: add ethool support for setting pause parameters


coccinelle warnings: (new ones prefixed by >>)

>> drivers/net/ethernet/qualcomm/emac/emac-ethtool.c:155:49-50: Unneeded semicolon

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] net: qcom/emac: fix semicolon.cocci warnings
  2017-02-07 19:41 [net-next:master 376/390] drivers/net/ethernet/qualcomm/emac/emac-ethtool.c:155:49-50: Unneeded semicolon kbuild test robot
@ 2017-02-07 19:42 ` kbuild test robot
  2017-02-08 18:40   ` David Miller
  0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2017-02-07 19:42 UTC (permalink / raw)
  To: Timur Tabi; +Cc: kbuild-all, netdev, linux-kernel

drivers/net/ethernet/qualcomm/emac/emac-ethtool.c:155:49-50: Unneeded semicolon


 Remove unneeded semicolon.

Generated by: scripts/coccinelle/misc/semicolon.cocci

CC: Timur Tabi <timur@codeaurora.org>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 emac-ethtool.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/net/ethernet/qualcomm/emac/emac-ethtool.c
+++ b/drivers/net/ethernet/qualcomm/emac/emac-ethtool.c
@@ -152,7 +152,7 @@ static void emac_get_pauseparam(struct n
 
 	pause->autoneg = adpt->automatic ? AUTONEG_ENABLE : AUTONEG_DISABLE;
 	pause->rx_pause = adpt->rx_flow_control ? 1 : 0;
-	pause->tx_pause = adpt->tx_flow_control ? 1 : 0;;
+	pause->tx_pause = adpt->tx_flow_control ? 1 : 0;
 }
 
 static int emac_set_pauseparam(struct net_device *netdev,

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] net: qcom/emac: fix semicolon.cocci warnings
  2017-02-07 19:42 ` [PATCH] net: qcom/emac: fix semicolon.cocci warnings kbuild test robot
@ 2017-02-08 18:40   ` David Miller
  0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2017-02-08 18:40 UTC (permalink / raw)
  To: fengguang.wu; +Cc: timur, kbuild-all, netdev, linux-kernel

From: kbuild test robot <fengguang.wu@intel.com>
Date: Wed, 8 Feb 2017 03:42:05 +0800

> drivers/net/ethernet/qualcomm/emac/emac-ethtool.c:155:49-50: Unneeded semicolon
> 
> 
>  Remove unneeded semicolon.
> 
> Generated by: scripts/coccinelle/misc/semicolon.cocci
> 
> CC: Timur Tabi <timur@codeaurora.org>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-02-08 18:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-07 19:41 [net-next:master 376/390] drivers/net/ethernet/qualcomm/emac/emac-ethtool.c:155:49-50: Unneeded semicolon kbuild test robot
2017-02-07 19:42 ` [PATCH] net: qcom/emac: fix semicolon.cocci warnings kbuild test robot
2017-02-08 18:40   ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).