From: Phil Sutter <phil@nwl.cc>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org
Subject: Re: [iproute PATCH 1/2] testsuite: skip link show test on big endian systems
Date: Wed, 8 Feb 2017 00:49:40 +0100 [thread overview]
Message-ID: <20170207234940.GN22796@orbyte.nwl.cc> (raw)
In-Reply-To: <20170207151249.19de5192@xeon-e3>
On Tue, Feb 07, 2017 at 03:12:49PM -0800, Stephen Hemminger wrote:
> On Wed, 8 Feb 2017 00:04:21 +0100
> Phil Sutter <phil@nwl.cc> wrote:
>
> > Netlink protocol is in host byte order, so the provided binary netlink
> > message buffer being in little endian format will cause the test to fail
> > on big endian systems.
> >
> > Signed-off-by: Phil Sutter <phil@nwl.cc>
>
> Maybe better to figure out how to generate the files in host order?
Yes, I had thought about that as well. Not sure whether it's worth the
effort though to write a program which constructs the messages and dumps
them into a file for 'ip monitor' to read. I think there's a certain
chance this will eventually test the message builder instead of iproute.
:)
Cheers, Phil
next prev parent reply other threads:[~2017-02-07 23:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 23:04 [iproute PATCH 0/2] Two minor testsuite fixes Phil Sutter
2017-02-07 23:04 ` [iproute PATCH 1/2] testsuite: skip link show test on big endian systems Phil Sutter
2017-02-07 23:12 ` Stephen Hemminger
2017-02-07 23:49 ` Phil Sutter [this message]
2017-02-07 23:04 ` [iproute PATCH 2/2] testsuite: Search kernel config in modules dir also Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170207234940.GN22796@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).