From: David Miller <davem@davemloft.net>
To: dsa@cumulusnetworks.com
Cc: netdev@vger.kernel.org, pupilla@libero.it
Subject: Re: [PATCH net] lwtunnel: valid encap attr check should return 0 when lwtunnel is disabled
Date: Wed, 08 Feb 2017 12:55:26 -0500 (EST) [thread overview]
Message-ID: <20170208.125526.1458078959708739209.davem@davemloft.net> (raw)
In-Reply-To: <1486574940-6513-1-git-send-email-dsa@cumulusnetworks.com>
From: David Ahern <dsa@cumulusnetworks.com>
Date: Wed, 8 Feb 2017 09:29:00 -0800
> An error was reported upgrading to 4.9.8:
> root@Typhoon:~# ip route add default table 210 nexthop dev eth0 via 10.68.64.1
> weight 1 nexthop dev eth0 via 10.68.64.2 weight 1
> RTNETLINK answers: Operation not supported
>
> The problem occurs when CONFIG_LWTUNNEL is not enabled and a multipath
> route is submitted.
>
> The point of lwtunnel_valid_encap_type_attr is catch modules that
> need to be loaded before any references are taken with rntl held. With
> CONFIG_LWTUNNEL disabled, there will be no modules to load so the
> lwtunnel_valid_encap_type_attr stub should just return 0.
>
> Fixes: 9ed59592e3e3 ("lwtunnel: fix autoload of lwt modules")
> Reported-by: pupilla@libero.it
> Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
Applied and queued up for -stable, thanks for fixing this so quickly David.
prev parent reply other threads:[~2017-02-08 17:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-08 17:29 [PATCH net] lwtunnel: valid encap attr check should return 0 when lwtunnel is disabled David Ahern
2017-02-08 17:55 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170208.125526.1458078959708739209.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=netdev@vger.kernel.org \
--cc=pupilla@libero.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).