From: David Miller <davem@davemloft.net>
To: dan.carpenter@oracle.com
Cc: andrew@lunn.ch, f.fainelli@gmail.com,
vivien.didelot@savoirfairelinux.com, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch net-next] net: dsa: bcm_sf2: cleanup bcm_sf2_cfp_rule_get() a little
Date: Wed, 08 Feb 2017 13:27:24 -0500 (EST) [thread overview]
Message-ID: <20170208.132724.942207581380658378.davem@davemloft.net> (raw)
In-Reply-To: <20170207131527.GB31552@mwanda>
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 7 Feb 2017 16:15:27 +0300
> This patch doesn't affect how the code works.
>
> My static checker complains that the mask and shift doesn't make sense
> because 0xffffff << 16 goes beyond the end of 32 bits. It should be
> 0xffff instead but the existing code won't cause runtime bugs.
>
> Also the casting here is not needed and not consistent with the rest of
> the code.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks Dan.
prev parent reply other threads:[~2017-02-08 18:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 13:15 [patch net-next] net: dsa: bcm_sf2: cleanup bcm_sf2_cfp_rule_get() a little Dan Carpenter
2017-02-08 18:27 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170208.132724.942207581380658378.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=dan.carpenter@oracle.com \
--cc=f.fainelli@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).