Re: [PATCH 1/3 net-next] enic: add devcmds for vxlan offload

[David Miller <davem@davemloft.net>]

From: Govindarajulu Varadarajan <gvaradar@cisco.com>
Date: Tue,  7 Feb 2017 23:28:23 -0800

> diff --git a/drivers/net/ethernet/cisco/enic/vnic_dev.c b/drivers/net/ethernet/cisco/enic/vnic_dev.c
> index 8f27df3207bc..9b3d670e1aa9 100644
> --- a/drivers/net/ethernet/cisco/enic/vnic_dev.c
> +++ b/drivers/net/ethernet/cisco/enic/vnic_dev.c
> @@ -1247,3 +1247,45 @@ int vnic_dev_classifier(struct vnic_dev *vdev, u8 cmd, u16 *entry,
>  
>  	return ret;
>  }
> +
> +int vnic_dev_overlay_offload_ctrl(struct vnic_dev *vdev, u8 overlay, u8 config)
> +{
> +	u64 a0;
> +	u64 a1;
> +	int wait = 1000;
> +	int ret;
> +
> +	a0 = overlay;
> +	a1 = config;

Please order local variable declarations from longest to shortest line.
And you can make these helpers more compact by doing the assignment in
the declaration:

	u64 a0 = overlay;
	u64 a1 = config;
	int wait = 1000;
	int ret;