netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Alexei Starovoitov <ast@fb.com>
Cc: "Mickaël Salaün" <mic@digikod.net>,
	linux-kernel@vger.kernel.org,
	"Daniel Borkmann" <daniel@iogearbox.net>,
	"David S . Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org, "Shuah Khan" <shuah@kernel.org>
Subject: Re: [PATCH net-next v3 04/11] bpf: Use bpf_load_program() from the library
Date: Wed, 8 Feb 2017 17:41:10 -0200	[thread overview]
Message-ID: <20170208194110.GB2162@redhat.com> (raw)
In-Reply-To: <589A5597.7090107@fb.com>

Em Tue, Feb 07, 2017 at 03:17:43PM -0800, Alexei Starovoitov escreveu:
> On 2/7/17 1:44 PM, Mickaël Salaün wrote:
> >-	union bpf_attr attr;
> >+	union bpf_attr attr = {};
> >
> >-	bzero(&attr, sizeof(attr));
 
> I think somebody mentioned that there are compilers out there
> that don't do it correctly, hence it was done with explicit bzero.
> Arnaldo, Wang, do you remember the details?

Yeah, lemme dig it...

- Arnaldo

  reply	other threads:[~2017-02-08 19:41 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-07 21:44 [PATCH net-next v3 00/11] Improve BPF selftests and use the library (net-next tree) Mickaël Salaün
2017-02-07 21:44 ` [PATCH net-next v3 01/11] tools: Sync {,tools/}include/uapi/linux/bpf.h Mickaël Salaün
2017-02-07 21:44 ` [PATCH net-next v3 02/11] bpf: Change the include directory for selftest Mickaël Salaün
2017-02-07 21:44 ` [PATCH net-next v3 03/11] bpf: Always test unprivileged programs Mickaël Salaün
2017-02-07 21:44 ` [PATCH net-next v3 04/11] bpf: Use bpf_load_program() from the library Mickaël Salaün
2017-02-07 23:17   ` Alexei Starovoitov
2017-02-08 19:41     ` Arnaldo Carvalho de Melo [this message]
2017-02-08 19:46     ` Arnaldo Carvalho de Melo
2017-02-08 20:08       ` Mickaël Salaün
2017-02-07 21:44 ` [PATCH net-next v3 05/11] bpf: Use bpf_map_update_elem() " Mickaël Salaün
2017-02-07 21:44 ` [PATCH net-next v3 06/11] bpf: Use bpf_map_lookup_elem() " Mickaël Salaün
2017-02-07 21:44 ` [PATCH net-next v3 07/11] bpf: Use bpf_map_delete_elem() " Mickaël Salaün
2017-02-07 21:44 ` [PATCH net-next v3 08/11] bpf: Use bpf_map_get_next_key() " Mickaël Salaün
2017-02-07 21:44 ` [PATCH net-next v3 09/11] bpf: Use bpf_create_map() " Mickaël Salaün
2017-02-07 21:44 ` [PATCH net-next v3 10/11] bpf: Remove bpf_sys.h from selftests Mickaël Salaün
2017-02-07 21:45 ` [PATCH net-next v3 11/11] bpf: Add test_tag to .gitignore Mickaël Salaün
2017-02-08 19:15 ` [PATCH net-next v3 00/11] Improve BPF selftests and use the library (net-next tree) David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170208194110.GB2162@redhat.com \
    --to=acme@redhat.com \
    --cc=ast@fb.com \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mic@digikod.net \
    --cc=netdev@vger.kernel.org \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).