* interrupt handling in the new aquantia ethernet driver
@ 2017-02-09 14:01 Christoph Hellwig
0 siblings, 0 replies; only message in thread
From: Christoph Hellwig @ 2017-02-09 14:01 UTC (permalink / raw)
To: David VomLehn; +Cc: David S. Miller, netdev
Hi David,
commit a4d36e20 ("net: ethernet: aquantia: PCI operations") adds some
realy odd interrupt related code, including a call to the long
gone pci_enable_msix() function. I first wondered how this compiles.
but the code happens to be under
#if AQ_CFG_FORCE_LEGACY_INT
where AQ_CFG_FORCE_LEGACY_INT is defined to 0U, so it isn't compiled in,
although probably not intentionally.
It would be good to a) kill that ifdef and b) either remove the MSI-X
code entirely or switch it to the proper pci_alloc_irq_vectors API.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-02-09 14:08 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-09 14:01 interrupt handling in the new aquantia ethernet driver Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).