netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netdev@vger.kernel.org
Subject: Re: [iproute PATCH v2 0/2] Two minor testsuite fixes
Date: Thu, 9 Feb 2017 17:31:10 -0800	[thread overview]
Message-ID: <20170209173110.2e0fffec@xeon-e3> (raw)
In-Reply-To: <20170209105055.2477-1-phil@nwl.cc>

On Thu,  9 Feb 2017 11:50:53 +0100
Phil Sutter <phil@nwl.cc> wrote:

> While playing around with testsuite, I noticed two minor nits which this
> series attempts to fix.
> 
> Changes since v1:
> - Replaced patch1 completely.
> 
> Phil Sutter (2):
>   testsuite: Generate nlmsg blob at runtime
>   testsuite: Search kernel config in modules dir also
> 
>  .gitignore                                |   2 +
>  testsuite/Makefile                        |   8 +++
>  testsuite/tests/ip/link/dev_wo_vf_rate.nl | Bin 14076 -> 0 bytes
>  testsuite/tools/Makefile                  |   2 +
>  testsuite/tools/generate_nlmsg.c          | 116 ++++++++++++++++++++++++++++++
>  5 files changed, 128 insertions(+)
>  delete mode 100644 testsuite/tests/ip/link/dev_wo_vf_rate.nl
>  create mode 100644 testsuite/tools/Makefile
>  create mode 100644 testsuite/tools/generate_nlmsg.c
> 

Nice. Applied.
I suspect the tests are rarely run because the core functionality doesn't change often.
But in new environments these would be really useful.

      parent reply	other threads:[~2017-02-10  1:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-09 10:50 [iproute PATCH v2 0/2] Two minor testsuite fixes Phil Sutter
2017-02-09 10:50 ` [iproute PATCH v2 1/2] testsuite: Generate nlmsg blob at runtime Phil Sutter
2017-02-09 10:50 ` [iproute PATCH v2 2/2] testsuite: Search kernel config in modules dir also Phil Sutter
2017-02-10  1:31 ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170209173110.2e0fffec@xeon-e3 \
    --to=stephen@networkplumber.org \
    --cc=netdev@vger.kernel.org \
    --cc=phil@nwl.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).