From: Jiri Pirko <jiri@resnulli.us>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, mlxsw@mellanox.com
Subject: Re: [patch net-next 5/6] sched: add missing curly braces in else branch in tc_ctl_tfilter
Date: Thu, 9 Feb 2017 22:45:52 +0100 [thread overview]
Message-ID: <20170209214552.GA1995@nanopsycho> (raw)
In-Reply-To: <0158ade7-fdf9-8aaf-4573-deb844a0cb92@mojatatu.com>
Thu, Feb 09, 2017 at 07:27:10PM CET, jhs@mojatatu.com wrote:
>On 17-02-09 08:38 AM, Jiri Pirko wrote:
>> From: Jiri Pirko <jiri@mellanox.com>
>>
>> Curly braces need to be there, for stylistic reasons.
>>
>> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
>> ---
>> net/sched/cls_api.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
>> index f44378c..48864ad 100644
>> --- a/net/sched/cls_api.c
>> +++ b/net/sched/cls_api.c
>> @@ -315,8 +315,9 @@ static int tc_ctl_tfilter(struct sk_buff *skb, struct nlmsghdr *n)
>> err = -EINVAL;
>> goto errout;
>> }
>> - } else
>> + } else {
>> tp = NULL;
>> + }
>> break;
>> }
>> }
>>
>
>Jiri, shall we engage in a long discussion about which rule says that
>you can put braces around one line branching? ;->
scripts/checkpatch.pl :)
>
>Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
>
>cheers,
>jamal
next prev parent reply other threads:[~2017-02-09 21:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-09 13:38 [patch net-next 0/6] sched: cls_api: small cleanup Jiri Pirko
2017-02-09 13:38 ` [patch net-next 1/6] sched: rename tcf_destroy to tcf_destroy_proto Jiri Pirko
2017-02-09 18:20 ` Jamal Hadi Salim
2017-02-09 13:38 ` [patch net-next 2/6] sched: move tcf_proto_destroy and tcf_destroy_chain helpers into cls_api Jiri Pirko
2017-02-09 18:21 ` Jamal Hadi Salim
2017-02-14 17:25 ` Sabrina Dubroca
2017-02-14 17:26 ` Jiri Pirko
2017-02-09 13:38 ` [patch net-next 3/6] sched: push TC filter protocol creation into a separate function Jiri Pirko
2017-02-09 18:23 ` Jamal Hadi Salim
2017-02-09 13:38 ` [patch net-next 4/6] sched: move err set right before goto errout in tc_ctl_tfilter Jiri Pirko
2017-02-09 18:25 ` Jamal Hadi Salim
2017-02-09 13:38 ` [patch net-next 5/6] sched: add missing curly braces in else branch " Jiri Pirko
2017-02-09 18:27 ` Jamal Hadi Salim
2017-02-09 21:45 ` Jiri Pirko [this message]
2017-02-09 13:39 ` [patch net-next 6/6] sched: check negative err value to safe one level of indent Jiri Pirko
2017-02-09 18:32 ` Jamal Hadi Salim
2017-02-10 16:38 ` [patch net-next 0/6] sched: cls_api: small cleanup David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170209214552.GA1995@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).