From: David Miller <davem@davemloft.net>
To: amir@vadai.me
Cc: netdev@vger.kernel.org, ogerlitz@mellanox.com, hadarh@mellanox.com
Subject: Re: [PATCH net-next V3 0/3] net/sched: act_pedit: Use offset relative to conventional network headers
Date: Fri, 10 Feb 2017 13:18:53 -0500 (EST) [thread overview]
Message-ID: <20170210.131853.2073979571755911124.davem@davemloft.net> (raw)
In-Reply-To: <20170207075608.8430-1-amir@vadai.me>
From: Amir Vadai <amir@vadai.me>
Date: Tue, 7 Feb 2017 09:56:05 +0200
> Some FW/HW parser APIs are such that they need to get the specific header type (e.g
> IPV4 or IPV6, TCP or UDP) and not only the networking level (e.g network or transport).
>
> Enhancing the UAPI to allow for specifying that, would allow the same flows to be
> set into both SW and HW.
>
> This patchset also makes pedit more robust. Currently fields offset is specified
> by offset relative to the ip header, while using negative offsets for
> MAC layer fields.
>
> This series enables the user to set offset relative to the relevant header.
>
> Usage example:
> $ tc filter add dev enp0s9 protocol ip parent ffff: \
> flower \
> ip_proto tcp \
> dst_port 80 \
> action \
> pedit munge ip ttl add 0xff \
> pedit munge tcp dport set 8080 \
> pipe action mirred egress redirect dev veth0
>
> Will forward traffic destined to tcp dport 80, while modifying the
> destination port to 8080, and decreasing the ttl by one.
>
> I've uploaded a draft for the userspace [2] to make it easier to review and
> test the patchset.
>
> [1] - http://patchwork.ozlabs.org/patch/700909/
> [2] - git: https://bitbucket.org/av42/iproute2.git
> branch: pedit
>
> Patchset was tested and applied on top of upstream commit bd092ad1463c ("Merge
> branch 'remove-__napi_complete_done'")
Series applied, thank you.
prev parent reply other threads:[~2017-02-10 18:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 7:56 [PATCH net-next V3 0/3] net/sched: act_pedit: Use offset relative to conventional network headers Amir Vadai
2017-02-07 7:56 ` [PATCH net-next V3 1/3] net/skbuff: Introduce skb_mac_offset() Amir Vadai
2017-02-07 7:56 ` [PATCH net-next V3 2/3] net/act_pedit: Support using offset relative to the conventional network headers Amir Vadai
2017-02-07 7:56 ` [PATCH net-next V3 3/3] net/act_pedit: Introduce 'add' operation Amir Vadai
2017-02-10 18:18 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170210.131853.2073979571755911124.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=amir@vadai.me \
--cc=hadarh@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).