From: David Miller <davem@davemloft.net>
To: ogerlitz@mellanox.com
Cc: daniel@iogearbox.net, jakub.kicinski@netronome.com,
john.r.fastabend@intel.com, amirva@vadai.me,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next 0/4] net/sched: Use TC skip flags to reflect HW offload status
Date: Fri, 10 Feb 2017 14:36:36 -0500 (EST) [thread overview]
Message-ID: <20170210.143636.253114480501653886.davem@davemloft.net> (raw)
In-Reply-To: <1486649888-2786-1-git-send-email-ogerlitz@mellanox.com>
From: Or Gerlitz <ogerlitz@mellanox.com>
Date: Thu, 9 Feb 2017 16:18:04 +0200
> Currently there is no way of querying whether a filter is
> offloaded to HW or not when using both policy (no flag).
>
> Reuse the skip flags to show the insertion status by setting
> the skip_hw flag in case the filter wasn't offloaded.
>
> The bpf patch is compile tested only, Daniel/Jakub, will
> appreciate your review/ack.
...
I'm learning towards suggesting that you use new flags, this way it
will be unambiguous whether we are running an old kernel.
If you just use the skip flag, it's impossible to tell the difference.
next prev parent reply other threads:[~2017-02-10 19:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-09 14:18 [PATCH net-next 0/4] net/sched: Use TC skip flags to reflect HW offload status Or Gerlitz
2017-02-09 14:18 ` [PATCH net-next 1/4] net/sched: cls_flower: Use " Or Gerlitz
2017-02-09 14:18 ` [PATCH net-next 2/4] net/sched: cls_matchall: Dump skip flags and use them " Or Gerlitz
2017-02-09 14:18 ` [PATCH net-next 3/4] net/sched: cls_u32: Use skip flags " Or Gerlitz
2017-02-09 14:18 ` [PATCH net-next 4/4] net/sched: cls_bpf: " Or Gerlitz
2017-02-10 1:22 ` Jakub Kicinski
2017-02-10 16:33 ` Or Gerlitz
2017-02-10 17:42 ` Jakub Kicinski
2017-02-12 9:46 ` Or Gerlitz
2017-02-12 9:59 ` Or Gerlitz
2017-02-10 22:19 ` Jakub Kicinski
2017-02-12 10:01 ` Or Gerlitz
2017-02-10 19:36 ` David Miller [this message]
2017-02-12 9:54 ` [PATCH net-next 0/4] net/sched: Use TC " Or Gerlitz
2017-02-12 16:50 ` David Miller
2017-02-13 18:10 ` Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170210.143636.253114480501653886.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=amirva@vadai.me \
--cc=daniel@iogearbox.net \
--cc=jakub.kicinski@netronome.com \
--cc=john.r.fastabend@intel.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).