From: David Miller <davem@davemloft.net>
To: cugyly@163.com
Cc: netdev@vger.kernel.org, Linyu.Yuan@alcatel-sbell.com.cn
Subject: Re: [PATH v3 net-next] net: remove member 'max' of struct scm_fp_list
Date: Sat, 11 Feb 2017 02:02:50 -0500 (EST) [thread overview]
Message-ID: <20170211.020250.864578992818171198.davem@davemloft.net> (raw)
In-Reply-To: <1486784477-3892-1-git-send-email-cugyly@163.com>
From: yuan linyu <cugyly@163.com>
Date: Sat, 11 Feb 2017 11:41:17 +0800
> From: yuan linyu <Linyu.Yuan@alcatel-sbell.com.cn>
>
> 'max' only used at three places in scm.c,
> 1. in scm_fp_copy(), fpl->max = SCM_MAX_FD;
> 2. in scm_fp_copy(), if (fpl->count + num > fpl->max)
> 3. in scm_fp_dup(), new_fpl->max = new_fpl->count;
> at place 3, the worst case is new_fpl->count = SCM_MAX_FD,
> so do a full size dup, then 'max' field will always
> SCM_MAX_FD and it can be removed.
>
> Signed-off-by: yuan linyu <Linyu.Yuan@alcatel-sbell.com.cn>
Please don't take this the wrong way, but I am ignoring your
patches on this issue. This is even more broken than your
previous two submissions.
Sorry.
prev parent reply other threads:[~2017-02-11 7:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-11 3:41 [PATH v3 net-next] net: remove member 'max' of struct scm_fp_list yuan linyu
2017-02-11 7:02 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170211.020250.864578992818171198.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Linyu.Yuan@alcatel-sbell.com.cn \
--cc=cugyly@163.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox