From: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
To: David Miller <davem@davemloft.net>
Cc: w-kwok2@ti.com, m-karicheri2@ti.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ethernet: ti: netcp_core: return netdev_tx_t in xmit
Date: Sat, 11 Feb 2017 03:08:41 +0200 [thread overview]
Message-ID: <20170211010839.GA4729@khorivan> (raw)
In-Reply-To: <20170210.144521.1768411194584186345.davem@davemloft.net>
On Fri, Feb 10, 2017 at 02:45:21PM -0500, David Miller wrote:
> From: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
> Date: Thu, 9 Feb 2017 16:24:14 +0200
>
> > @@ -1300,7 +1301,7 @@ static int netcp_ndo_start_xmit(struct sk_buff *skb, struct net_device *ndev)
> > dev_warn(netcp->ndev_dev, "padding failed (%d), packet dropped\n",
> > ret);
> > tx_stats->tx_dropped++;
> > - return ret;
> > + return NETDEV_TX_BUSY;
> > }
> > skb->len = NETCP_MIN_PACKET_SIZE;
> > }
> > @@ -1329,7 +1330,7 @@ static int netcp_ndo_start_xmit(struct sk_buff *skb, struct net_device *ndev)
> > if (desc)
> > netcp_free_tx_desc_chain(netcp, desc, sizeof(*desc));
> > dev_kfree_skb(skb);
> > - return ret;
> > + return NETDEV_TX_BUSY;
> > }
>
> I really think these should be returning NET_XMIT_DROP.
Yes, it seems here can be a little more changes then, will send new version
later.
prev parent reply other threads:[~2017-02-11 1:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-09 14:24 [PATCH] net: ethernet: ti: netcp_core: return netdev_tx_t in xmit Ivan Khoronzhuk
2017-02-10 19:45 ` David Miller
2017-02-11 1:08 ` Ivan Khoronzhuk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170211010839.GA4729@khorivan \
--to=ivan.khoronzhuk@linaro.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=netdev@vger.kernel.org \
--cc=w-kwok2@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).