From: David Miller <davem@davemloft.net>
To: tlfalcon@linux.vnet.ibm.com
Cc: netdev@vger.kernel.org, nfont@linux.vnet.ibm.com,
jallen@linux.vnet.ibm.com
Subject: Re: [PATCH net v2] ibmvnic: Fix initial MTU settings
Date: Tue, 14 Feb 2017 14:58:10 -0500 (EST) [thread overview]
Message-ID: <20170214.145810.826153305226199095.davem@davemloft.net> (raw)
In-Reply-To: <1487089379-29498-1-git-send-email-tlfalcon@linux.vnet.ibm.com>
From: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
Date: Tue, 14 Feb 2017 10:22:59 -0600
> In the current driver, the MTU is set to the maximum value
> capable for the backing device. This decision turned out to
> be a mistake as it led to confusion among users. The expected
> initial MTU value used for other IBM vNIC capable operating
> systems is 1500, with the maximum value (9000) reserved for
> when Jumbo frames are enabled. This patch sets the MTU to
> the default value for a net device.
>
> It also corrects a discrepancy between MTU values received from
> firmware, which includes the ethernet header length, and net
> device MTU values.
>
> Finally, it removes redundant min/max MTU assignments after device
> initialization.
>
> Signed-off-by: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
> ---
> v2: included more detailed commit message addressing why
> this patch is needed
Applied, thanks.
prev parent reply other threads:[~2017-02-14 19:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 16:22 [PATCH net v2] ibmvnic: Fix initial MTU settings Thomas Falcon
2017-02-14 19:58 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170214.145810.826153305226199095.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jallen@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=nfont@linux.vnet.ibm.com \
--cc=tlfalcon@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).