* [PATCH net-next] net_sched: nla_memdup_cookie() can be static
@ 2017-02-14 14:19 Wei Yongjun
2017-02-14 20:02 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2017-02-14 14:19 UTC (permalink / raw)
To: Jamal Hadi Salim; +Cc: Wei Yongjun, netdev
From: Wei Yongjun <weiyongjun1@huawei.com>
Fixes the following sparse warning:
net/sched/act_api.c:532:5: warning:
symbol 'nla_memdup_cookie' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
net/sched/act_api.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sched/act_api.c b/net/sched/act_api.c
index 3c5e29b..f219ff3 100644
--- a/net/sched/act_api.c
+++ b/net/sched/act_api.c
@@ -529,7 +529,7 @@ int tcf_action_dump(struct sk_buff *skb, struct list_head *actions,
return err;
}
-int nla_memdup_cookie(struct tc_action *a, struct nlattr **tb)
+static int nla_memdup_cookie(struct tc_action *a, struct nlattr **tb)
{
a->act_cookie = kzalloc(sizeof(*a->act_cookie), GFP_KERNEL);
if (!a->act_cookie)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net_sched: nla_memdup_cookie() can be static
2017-02-14 14:19 [PATCH net-next] net_sched: nla_memdup_cookie() can be static Wei Yongjun
@ 2017-02-14 20:02 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-02-14 20:02 UTC (permalink / raw)
To: weiyj.lk; +Cc: jhs, weiyongjun1, netdev
From: Wei Yongjun <weiyj.lk@gmail.com>
Date: Tue, 14 Feb 2017 14:19:32 +0000
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fixes the following sparse warning:
>
> net/sched/act_api.c:532:5: warning:
> symbol 'nla_memdup_cookie' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-14 20:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-14 14:19 [PATCH net-next] net_sched: nla_memdup_cookie() can be static Wei Yongjun
2017-02-14 20:02 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).