* [PATCH] pch_gbe: Omit private ndo_get_stats function
@ 2017-02-14 16:47 Tobias Klauser
  2017-02-14 20:04 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Tobias Klauser @ 2017-02-14 16:47 UTC (permalink / raw)
  To: netdev
pch_gbe_get_stats() just returns dev->stats so we can leave it out
altogether and let dev_get_stats() do the job.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
 drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 12 ------------
 1 file changed, 12 deletions(-)
diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
index f9e4e8eca665..5ae9681a2da7 100644
--- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
+++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
@@ -2149,17 +2149,6 @@ static int pch_gbe_xmit_frame(struct sk_buff *skb, struct net_device *netdev)
 }
 
 /**
- * pch_gbe_get_stats - Get System Network Statistics
- * @netdev:  Network interface device structure
- * Returns:  The current stats
- */
-static struct net_device_stats *pch_gbe_get_stats(struct net_device *netdev)
-{
-	/* only return the current stats */
-	return &netdev->stats;
-}
-
-/**
  * pch_gbe_set_multi - Multicast and Promiscuous mode set
  * @netdev:   Network interface device structure
  */
@@ -2420,7 +2409,6 @@ static const struct net_device_ops pch_gbe_netdev_ops = {
 	.ndo_open = pch_gbe_open,
 	.ndo_stop = pch_gbe_stop,
 	.ndo_start_xmit = pch_gbe_xmit_frame,
-	.ndo_get_stats = pch_gbe_get_stats,
 	.ndo_set_mac_address = pch_gbe_set_mac,
 	.ndo_tx_timeout = pch_gbe_tx_timeout,
 	.ndo_change_mtu = pch_gbe_change_mtu,
-- 
2.11.0
^ permalink raw reply related	[flat|nested] 2+ messages in thread
* Re: [PATCH] pch_gbe: Omit private ndo_get_stats function
  2017-02-14 16:47 [PATCH] pch_gbe: Omit private ndo_get_stats function Tobias Klauser
@ 2017-02-14 20:04 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-02-14 20:04 UTC (permalink / raw)
  To: tklauser; +Cc: netdev
From: Tobias Klauser <tklauser@distanz.ch>
Date: Tue, 14 Feb 2017 17:47:12 +0100
> pch_gbe_get_stats() just returns dev->stats so we can leave it out
> altogether and let dev_get_stats() do the job.
> 
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Also applied to net-next, thanks.
^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-14 20:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-14 16:47 [PATCH] pch_gbe: Omit private ndo_get_stats function Tobias Klauser
2017-02-14 20:04 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).