netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Pirko <jiri@resnulli.us>
To: Sabrina Dubroca <sd@queasysnail.net>
Cc: netdev@vger.kernel.org, davem@davemloft.net, jhs@mojatatu.com,
	mlxsw@mellanox.com
Subject: Re: [patch net-next 2/6] sched: move tcf_proto_destroy and tcf_destroy_chain helpers into cls_api
Date: Tue, 14 Feb 2017 18:26:42 +0100	[thread overview]
Message-ID: <20170214172642.GA21867@nanopsycho> (raw)
In-Reply-To: <20170214172501.GA4182@bistromath.localdomain>

Tue, Feb 14, 2017 at 06:25:01PM CET, sd@queasysnail.net wrote:
>Hi Jiri,
>
>2017-02-09, 14:38:56 +0100, Jiri Pirko wrote:
>> From: Jiri Pirko <jiri@mellanox.com>
>> 
>> Creation is done in this file, move destruction to be at the same place.
>> 
>> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
>> ---
>>  include/net/pkt_cls.h     |  2 ++
>>  include/net/sch_generic.h |  2 --
>>  net/sched/cls_api.c       | 21 +++++++++++++++++++++
>>  net/sched/sch_api.c       | 22 ----------------------
>>  net/sched/sch_atm.c       |  1 +
>>  net/sched/sch_cbq.c       |  1 +
>>  net/sched/sch_choke.c     |  1 +
>>  net/sched/sch_dsmark.c    |  1 +
>>  net/sched/sch_fq_codel.c  |  1 +
>>  net/sched/sch_htb.c       |  1 +
>>  net/sched/sch_ingress.c   |  1 +
>>  net/sched/sch_multiq.c    |  2 +-
>>  net/sched/sch_prio.c      |  2 +-
>>  net/sched/sch_sfb.c       |  1 +
>>  net/sched/sch_sfq.c       |  1 +
>>  15 files changed, 34 insertions(+), 26 deletions(-)
>
>This broke the build for !NET_CLS:
>
>net/built-in.o: In function `fq_codel_destroy':
>/home/sab/linux/net-next/net/sched/sch_fq_codel.c:468: undefined reference to `tcf_destroy_chain'

Will fix. Thanks.

  reply	other threads:[~2017-02-14 17:26 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-09 13:38 [patch net-next 0/6] sched: cls_api: small cleanup Jiri Pirko
2017-02-09 13:38 ` [patch net-next 1/6] sched: rename tcf_destroy to tcf_destroy_proto Jiri Pirko
2017-02-09 18:20   ` Jamal Hadi Salim
2017-02-09 13:38 ` [patch net-next 2/6] sched: move tcf_proto_destroy and tcf_destroy_chain helpers into cls_api Jiri Pirko
2017-02-09 18:21   ` Jamal Hadi Salim
2017-02-14 17:25   ` Sabrina Dubroca
2017-02-14 17:26     ` Jiri Pirko [this message]
2017-02-09 13:38 ` [patch net-next 3/6] sched: push TC filter protocol creation into a separate function Jiri Pirko
2017-02-09 18:23   ` Jamal Hadi Salim
2017-02-09 13:38 ` [patch net-next 4/6] sched: move err set right before goto errout in tc_ctl_tfilter Jiri Pirko
2017-02-09 18:25   ` Jamal Hadi Salim
2017-02-09 13:38 ` [patch net-next 5/6] sched: add missing curly braces in else branch " Jiri Pirko
2017-02-09 18:27   ` Jamal Hadi Salim
2017-02-09 21:45     ` Jiri Pirko
2017-02-09 13:39 ` [patch net-next 6/6] sched: check negative err value to safe one level of indent Jiri Pirko
2017-02-09 18:32   ` Jamal Hadi Salim
2017-02-10 16:38 ` [patch net-next 0/6] sched: cls_api: small cleanup David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170214172642.GA21867@nanopsycho \
    --to=jiri@resnulli.us \
    --cc=davem@davemloft.net \
    --cc=jhs@mojatatu.com \
    --cc=mlxsw@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=sd@queasysnail.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).