From: Andrew Lunn <andrew@lunn.ch>
To: mdf@kernel.org
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
moritz.fischer@ettus.com,
Nicolas Ferre <nicolas.ferre@microchip.com>
Subject: Re: [PATCH] net: ethernet: cadence: Add fixed-link functionality
Date: Wed, 15 Feb 2017 23:12:49 +0100 [thread overview]
Message-ID: <20170215221249.GB6096@lunn.ch> (raw)
In-Reply-To: <1487191445-5353-1-git-send-email-mdf@kernel.org>
> @@ -3342,8 +3371,18 @@ static int macb_probe(struct platform_device *pdev)
> macb_get_hwaddr(bp);
>
> /* Power up the PHY if there is a GPIO reset */
> - phy_node = of_get_next_available_child(np, NULL);
> - if (phy_node) {
> + phy_node = of_parse_phandle(np, "phy-handle", 0);
> + if (!phy_node && of_phy_is_fixed_link(np)) {
> + err = of_phy_register_fixed_link(np);
Hi Moritz
I don't see any calls to of_phy_deregister_fixed_link(), either in the
error path, or the remove code.
Andrew
next prev parent reply other threads:[~2017-02-15 22:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-15 20:44 [PATCH] net: ethernet: cadence: Add fixed-link functionality mdf
2017-02-15 20:57 ` Florian Fainelli
2017-02-15 21:04 ` Moritz Fischer
2017-02-15 22:12 ` Andrew Lunn [this message]
2017-02-15 22:30 ` Moritz Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170215221249.GB6096@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=moritz.fischer@ettus.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox