* [PATCH net-next] bridge: vlan_tunnel: explicitly reset metadata attrs to NULL on failure
@ 2017-02-16 19:29 Roopa Prabhu
2017-02-17 9:49 ` Nikolay Aleksandrov
2017-02-17 18:33 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Roopa Prabhu @ 2017-02-16 19:29 UTC (permalink / raw)
To: davem; +Cc: netdev, nikolay
From: Roopa Prabhu <roopa@cumulusnetworks.com>
Fixes: efa5356b0d97 ("bridge: per vlan dst_metadata netlink support")
Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
---
net/bridge/br_vlan_tunnel.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/bridge/br_vlan_tunnel.c b/net/bridge/br_vlan_tunnel.c
index b2b79a0..6d2c4ee 100644
--- a/net/bridge/br_vlan_tunnel.c
+++ b/net/bridge/br_vlan_tunnel.c
@@ -85,6 +85,8 @@ static int __vlan_tunnel_info_add(struct net_bridge_vlan_group *vg,
return 0;
out:
dst_release(&vlan->tinfo.tunnel_dst->dst);
+ vlan->tinfo.tunnel_dst = NULL;
+ vlan->tinfo.tunnel_id = 0;
return err;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] bridge: vlan_tunnel: explicitly reset metadata attrs to NULL on failure
2017-02-16 19:29 [PATCH net-next] bridge: vlan_tunnel: explicitly reset metadata attrs to NULL on failure Roopa Prabhu
@ 2017-02-17 9:49 ` Nikolay Aleksandrov
2017-02-17 18:33 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Nikolay Aleksandrov @ 2017-02-17 9:49 UTC (permalink / raw)
To: Roopa Prabhu, davem; +Cc: netdev
On 16/02/17 20:29, Roopa Prabhu wrote:
> From: Roopa Prabhu <roopa@cumulusnetworks.com>
>
> Fixes: efa5356b0d97 ("bridge: per vlan dst_metadata netlink support")
> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
> ---
> net/bridge/br_vlan_tunnel.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/net/bridge/br_vlan_tunnel.c b/net/bridge/br_vlan_tunnel.c
> index b2b79a0..6d2c4ee 100644
> --- a/net/bridge/br_vlan_tunnel.c
> +++ b/net/bridge/br_vlan_tunnel.c
> @@ -85,6 +85,8 @@ static int __vlan_tunnel_info_add(struct net_bridge_vlan_group *vg,
> return 0;
> out:
> dst_release(&vlan->tinfo.tunnel_dst->dst);
> + vlan->tinfo.tunnel_dst = NULL;
> + vlan->tinfo.tunnel_id = 0;
>
> return err;
> }
>
Reviewed-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] bridge: vlan_tunnel: explicitly reset metadata attrs to NULL on failure
2017-02-16 19:29 [PATCH net-next] bridge: vlan_tunnel: explicitly reset metadata attrs to NULL on failure Roopa Prabhu
2017-02-17 9:49 ` Nikolay Aleksandrov
@ 2017-02-17 18:33 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-02-17 18:33 UTC (permalink / raw)
To: roopa; +Cc: netdev, nikolay
From: Roopa Prabhu <roopa@cumulusnetworks.com>
Date: Thu, 16 Feb 2017 11:29:21 -0800
> From: Roopa Prabhu <roopa@cumulusnetworks.com>
>
> Fixes: efa5356b0d97 ("bridge: per vlan dst_metadata netlink support")
> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-17 18:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-16 19:29 [PATCH net-next] bridge: vlan_tunnel: explicitly reset metadata attrs to NULL on failure Roopa Prabhu
2017-02-17 9:49 ` Nikolay Aleksandrov
2017-02-17 18:33 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).