From: David Miller <davem@davemloft.net>
To: andreyknvl@google.com
Cc: netdev@vger.kernel.org, edumazet@google.com,
gerrit@erg.abdn.ac.uk, dvyukov@google.com, kcc@google.com,
glider@google.com
Subject: Re: [PATCH] dccp: fix freeing skb too early for IPV6_RECVPKTINFO
Date: Fri, 17 Feb 2017 13:37:08 -0500 (EST) [thread overview]
Message-ID: <20170217.133708.1915562990938384609.davem@davemloft.net> (raw)
In-Reply-To: <20170216162246.12783-1-andreyknvl@google.com>
From: Andrey Konovalov <andreyknvl@google.com>
Date: Thu, 16 Feb 2017 17:22:46 +0100
> In the current DCCP implementation an skb for a DCCP_PKT_REQUEST packet
> is forcibly freed via __kfree_skb in dccp_rcv_state_process if
> dccp_v6_conn_request successfully returns.
>
> However, if IPV6_RECVPKTINFO is set on a socket, the address of the skb
> is saved to ireq->pktopts and the ref count for skb is incremented in
> dccp_v6_conn_request, so skb is still in use. Nevertheless, it gets freed
> in dccp_rcv_state_process.
>
> Fix by calling consume_skb instead of doing goto discard and therefore
> calling __kfree_skb.
>
> Similar fixes for TCP:
>
> fb7e2399ec17f1004c0e0ccfd17439f8759ede01 [TCP]: skb is unexpectedly freed.
> 0aea76d35c9651d55bbaf746e7914e5f9ae5a25d tcp: SYN packets are now
> simply consumed
>
> Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2017-02-17 18:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-16 16:22 [PATCH] dccp: fix freeing skb too early for IPV6_RECVPKTINFO Andrey Konovalov
2017-02-16 18:28 ` Eric Dumazet
2017-02-17 18:37 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170217.133708.1915562990938384609.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andreyknvl@google.com \
--cc=dvyukov@google.com \
--cc=edumazet@google.com \
--cc=gerrit@erg.abdn.ac.uk \
--cc=glider@google.com \
--cc=kcc@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox