* [PATCH] of_mdio: Add "broadcom,bcm5241" to the whitelist.
@ 2017-02-17 20:04 David Daney
2017-02-17 20:09 ` Florian Fainelli
2017-02-19 23:20 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: David Daney @ 2017-02-17 20:04 UTC (permalink / raw)
To: Florian Fainelli, netdev, Rob Herring, Frank Rowand
Cc: linux-kernel, David Daney
Some Cavium dev boards have firmware which doesn't supply a proper
ethernet-phy-ieee802.3-c22" compatible property. Restore these boards
to working order by whitelisting this compatible value.
Signed-off-by: David Daney <david.daney@cavium.com>
---
drivers/of/of_mdio.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c
index 262281b..0b29798 100644
--- a/drivers/of/of_mdio.c
+++ b/drivers/of/of_mdio.c
@@ -147,6 +147,7 @@ EXPORT_SYMBOL(of_mdio_parse_addr);
*/
static const struct of_device_id whitelist_phys[] = {
{ .compatible = "brcm,40nm-ephy" },
+ { .compatible = "broadcom,bcm5241" },
{ .compatible = "marvell,88E1111", },
{ .compatible = "marvell,88e1116", },
{ .compatible = "marvell,88e1118", },
--
2.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] of_mdio: Add "broadcom,bcm5241" to the whitelist.
2017-02-17 20:04 [PATCH] of_mdio: Add "broadcom,bcm5241" to the whitelist David Daney
@ 2017-02-17 20:09 ` Florian Fainelli
2017-02-17 21:41 ` David Daney
2017-02-19 23:20 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Florian Fainelli @ 2017-02-17 20:09 UTC (permalink / raw)
To: David Daney, netdev, Rob Herring, Frank Rowand; +Cc: linux-kernel
On 02/17/2017 12:04 PM, David Daney wrote:
> Some Cavium dev boards have firmware which doesn't supply a proper
> ethernet-phy-ieee802.3-c22" compatible property. Restore these boards
> to working order by whitelisting this compatible value.
>
> Signed-off-by: David Daney <david.daney@cavium.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> drivers/of/of_mdio.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c
> index 262281b..0b29798 100644
> --- a/drivers/of/of_mdio.c
> +++ b/drivers/of/of_mdio.c
> @@ -147,6 +147,7 @@ EXPORT_SYMBOL(of_mdio_parse_addr);
> */
> static const struct of_device_id whitelist_phys[] = {
> { .compatible = "brcm,40nm-ephy" },
> + { .compatible = "broadcom,bcm5241" },
And that's not the vendor prefix from vendor-prefixes.txt.
> { .compatible = "marvell,88E1111", },
> { .compatible = "marvell,88e1116", },
> { .compatible = "marvell,88e1118", },
>
--
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] of_mdio: Add "broadcom,bcm5241" to the whitelist.
2017-02-17 20:09 ` Florian Fainelli
@ 2017-02-17 21:41 ` David Daney
0 siblings, 0 replies; 4+ messages in thread
From: David Daney @ 2017-02-17 21:41 UTC (permalink / raw)
To: Florian Fainelli, David Daney, netdev, Rob Herring, Frank Rowand
Cc: linux-kernel
On 02/17/2017 12:09 PM, Florian Fainelli wrote:
> On 02/17/2017 12:04 PM, David Daney wrote:
>> Some Cavium dev boards have firmware which doesn't supply a proper
>> ethernet-phy-ieee802.3-c22" compatible property. Restore these boards
>> to working order by whitelisting this compatible value.
>>
>> Signed-off-by: David Daney <david.daney@cavium.com>
>
> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
>
>> ---
>> drivers/of/of_mdio.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c
>> index 262281b..0b29798 100644
>> --- a/drivers/of/of_mdio.c
>> +++ b/drivers/of/of_mdio.c
>> @@ -147,6 +147,7 @@ EXPORT_SYMBOL(of_mdio_parse_addr);
>> */
>> static const struct of_device_id whitelist_phys[] = {
>> { .compatible = "brcm,40nm-ephy" },
>> + { .compatible = "broadcom,bcm5241" },
>
> And that's not the vendor prefix from vendor-prefixes.txt.
No, that dts containing this value predates vendor-prefixes.txt.
Previous to
commit 801a8ef54e8b ("of: phy: Only register a phy device for phys"),
the form of the compatible string didn't matter for phys
>
>
>> { .compatible = "marvell,88E1111", },
>> { .compatible = "marvell,88e1116", },
>> { .compatible = "marvell,88e1118", },
>>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] of_mdio: Add "broadcom,bcm5241" to the whitelist.
2017-02-17 20:04 [PATCH] of_mdio: Add "broadcom,bcm5241" to the whitelist David Daney
2017-02-17 20:09 ` Florian Fainelli
@ 2017-02-19 23:20 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2017-02-19 23:20 UTC (permalink / raw)
To: david.daney; +Cc: f.fainelli, netdev, robh+dt, frowand.list, linux-kernel
From: David Daney <david.daney@cavium.com>
Date: Fri, 17 Feb 2017 12:04:12 -0800
> Some Cavium dev boards have firmware which doesn't supply a proper
> ethernet-phy-ieee802.3-c22" compatible property. Restore these boards
> to working order by whitelisting this compatible value.
>
> Signed-off-by: David Daney <david.daney@cavium.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-02-19 23:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-17 20:04 [PATCH] of_mdio: Add "broadcom,bcm5241" to the whitelist David Daney
2017-02-17 20:09 ` Florian Fainelli
2017-02-17 21:41 ` David Daney
2017-02-19 23:20 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).