From: Andrew Lunn <andrew@lunn.ch>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@savoirfairelinux.com,
"David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH net-next v2 3/6] net: dsa: mv88e6xxx: add support for 6390 ATU Move
Date: Fri, 17 Feb 2017 22:38:02 +0100 [thread overview]
Message-ID: <20170217213802.GI6096@lunn.ch> (raw)
In-Reply-To: <20170217150531.2181-4-vivien.didelot@savoirfairelinux.com>
On Fri, Feb 17, 2017 at 10:05:28AM -0500, Vivien Didelot wrote:
> The 6390 family of Marvell chips uses 5 bits to describe the ToPort and
> FromPort values of PortVec in the ATU Move operation, while older
> switches use 0xf.
Hi Vivien
Since you say 5 bits for 6390, it would be better to say 4 bits for
older switches.
Otherwise:
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2017-02-17 21:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-17 15:05 [PATCH net-next v2 0/6] net: dsa: mv88e6xxx: 88E6390 ATU/VTU Vivien Didelot
2017-02-17 15:05 ` [PATCH net-next v2 1/6] net: dsa: mv88e6xxx: add port mask helper Vivien Didelot
2017-02-17 21:26 ` Andrew Lunn
2017-02-17 15:05 ` [PATCH net-next v2 2/6] net: dsa: mv88e6xxx: move ATU code in its own file Vivien Didelot
2017-02-17 21:35 ` Andrew Lunn
2017-02-17 21:54 ` Vivien Didelot
2017-02-17 22:36 ` Andrew Lunn
2017-02-17 23:35 ` David Miller
2017-02-17 15:05 ` [PATCH net-next v2 3/6] net: dsa: mv88e6xxx: add support for 6390 ATU Move Vivien Didelot
2017-02-17 21:38 ` Andrew Lunn [this message]
2017-02-17 15:05 ` [PATCH net-next v2 4/6] net: dsa: mv88e6xxx: move VTU code to its own file Vivien Didelot
2017-02-17 21:46 ` Andrew Lunn
2017-02-17 15:05 ` [PATCH net-next v2 5/6] net: dsa: mv88e6xxx: add VTU ops Vivien Didelot
2017-02-17 21:49 ` Andrew Lunn
2017-02-17 15:05 ` [PATCH net-next v2 6/6] net: dsa: mv88e6xxx: add support for 6390 VTU Vivien Didelot
2017-02-17 21:53 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170217213802.GI6096@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).