From: Stephen Hemminger <stephen@networkplumber.org>
To: David Ahern <dsa@cumulusnetworks.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2 v2] ip route: Make name of protocol 0 consistent
Date: Sat, 18 Feb 2017 16:09:04 -0800 [thread overview]
Message-ID: <20170218160904.552af369@xeon-e3> (raw)
In-Reply-To: <1487017313-8000-1-git-send-email-dsa@cumulusnetworks.com>
On Mon, 13 Feb 2017 12:21:53 -0800
David Ahern <dsa@cumulusnetworks.com> wrote:
> iproute2 can inconsistently show the name of protocol 0 if a route with
> a custom protocol is added. For example:
> dsa@cartman:~$ ip -6 ro ls table all | egrep 'proto none|proto unspec'
> local ::1 dev lo table local proto none metric 0 pref medium
> local fe80::225:90ff:fecb:1c18 dev lo table local proto none metric 0 pref medium
> local fe80::92e2:baff:fe5c:da5d dev lo table local proto none metric 0 pref medium
>
> protocol 0 is pretty printed as "none". Add a route with a custom protocol:
> dsa@cartman:~$ sudo ip -6 ro add 2001:db8:200::1/128 dev eth0 proto 123
>
> And now display has switched from "none" to "unspec":
> dsa@cartman:~$ ip -6 ro ls table all | egrep 'proto none|proto unspec'
> local ::1 dev lo table local proto unspec metric 0 pref medium
> local fe80::225:90ff:fecb:1c18 dev lo table local proto unspec metric 0 pref medium
> local fe80::92e2:baff:fe5c:da5d dev lo table local proto unspec metric 0 pref medium
>
> The rt_protos file has the id to name mapping as "unspec" while
> rtnl_rtprot_tab[0] has "none". The presence of a custom protocol id
> triggers reading the rt_protos file and overwriting the string in
> rtnl_rtprot_tab. All of this is logic from 2004 and earlier.
>
> Update rtnl_rtprot_tab to "unspec" to match the enum value.
>
> Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
Applied, thanks.
prev parent reply other threads:[~2017-02-19 0:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-13 20:21 [PATCH iproute2 v2] ip route: Make name of protocol 0 consistent David Ahern
2017-02-19 0:09 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170218160904.552af369@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dsa@cumulusnetworks.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).