* [PATCH iproute] tc: matchall: Print skip flags when dumping a filter
@ 2017-02-09 13:10 Or Gerlitz
2017-02-10 15:36 ` Simon Horman
2017-02-19 0:09 ` Stephen Hemminger
0 siblings, 2 replies; 3+ messages in thread
From: Or Gerlitz @ 2017-02-09 13:10 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: netdev, Or Gerlitz
Print the skip flags when we dump a filter.
Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Acked by: Yotam Gigi <yotamg@mellanox.com>
---
tc/f_matchall.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/tc/f_matchall.c b/tc/f_matchall.c
index 04e524e..ac48630 100644
--- a/tc/f_matchall.c
+++ b/tc/f_matchall.c
@@ -130,6 +130,15 @@ static int matchall_print_opt(struct filter_util *qu, FILE *f,
sprint_tc_classid(rta_getattr_u32(tb[TCA_MATCHALL_CLASSID]), b1));
}
+ if (tb[TCA_MATCHALL_FLAGS]) {
+ __u32 flags = rta_getattr_u32(tb[TCA_MATCHALL_FLAGS]);
+
+ if (flags & TCA_CLS_FLAGS_SKIP_HW)
+ fprintf(f, "\n skip_hw");
+ if (flags & TCA_CLS_FLAGS_SKIP_SW)
+ fprintf(f, "\n skip_sw");
+ }
+
if (tb[TCA_MATCHALL_ACT])
tc_print_action(f, tb[TCA_MATCHALL_ACT]);
--
2.3.7
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH iproute] tc: matchall: Print skip flags when dumping a filter
2017-02-09 13:10 [PATCH iproute] tc: matchall: Print skip flags when dumping a filter Or Gerlitz
@ 2017-02-10 15:36 ` Simon Horman
2017-02-19 0:09 ` Stephen Hemminger
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2017-02-10 15:36 UTC (permalink / raw)
To: Or Gerlitz; +Cc: Stephen Hemminger, netdev
On Thu, Feb 09, 2017 at 03:10:14PM +0200, Or Gerlitz wrote:
> Print the skip flags when we dump a filter.
>
> Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
> Acked by: Yotam Gigi <yotamg@mellanox.com>
This appears to be consistent with other classifiers that support these
flags.
Reviewed-by: Simon Horman <simon.horman@netronome.com>
> ---
> tc/f_matchall.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/tc/f_matchall.c b/tc/f_matchall.c
> index 04e524e..ac48630 100644
> --- a/tc/f_matchall.c
> +++ b/tc/f_matchall.c
> @@ -130,6 +130,15 @@ static int matchall_print_opt(struct filter_util *qu, FILE *f,
> sprint_tc_classid(rta_getattr_u32(tb[TCA_MATCHALL_CLASSID]), b1));
> }
>
> + if (tb[TCA_MATCHALL_FLAGS]) {
> + __u32 flags = rta_getattr_u32(tb[TCA_MATCHALL_FLAGS]);
> +
> + if (flags & TCA_CLS_FLAGS_SKIP_HW)
> + fprintf(f, "\n skip_hw");
> + if (flags & TCA_CLS_FLAGS_SKIP_SW)
> + fprintf(f, "\n skip_sw");
> + }
> +
> if (tb[TCA_MATCHALL_ACT])
> tc_print_action(f, tb[TCA_MATCHALL_ACT]);
>
> --
> 2.3.7
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH iproute] tc: matchall: Print skip flags when dumping a filter
2017-02-09 13:10 [PATCH iproute] tc: matchall: Print skip flags when dumping a filter Or Gerlitz
2017-02-10 15:36 ` Simon Horman
@ 2017-02-19 0:09 ` Stephen Hemminger
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Hemminger @ 2017-02-19 0:09 UTC (permalink / raw)
To: Or Gerlitz; +Cc: netdev
On Thu, 9 Feb 2017 15:10:14 +0200
Or Gerlitz <ogerlitz@mellanox.com> wrote:
> Print the skip flags when we dump a filter.
>
> Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
> Acked by: Yotam Gigi <yotamg@mellanox.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-19 0:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-09 13:10 [PATCH iproute] tc: matchall: Print skip flags when dumping a filter Or Gerlitz
2017-02-10 15:36 ` Simon Horman
2017-02-19 0:09 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).