From: Peter Senna Tschudin <peter.senna@collabora.com>
To: Romain Perier <romain.perier@collabora.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
Doug Ledford <dledford@redhat.com>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
jeffrey.t.kirsher@intel.com,
"David S. Miller" <davem@davemloft.net>,
stas.yakovlev@gmail.com,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-rdma@vger.kernel.org, netdev@vger.kernel.org,
linux-usb@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org,
Peter Senna Tschudin <peter.senna@collabora.co.uk>
Subject: Re: [RFC v2 00/20] Replace PCI pool by DMA pool API
Date: Sat, 18 Feb 2017 19:46:59 +0100 [thread overview]
Message-ID: <20170218184659.GD13698@collabora.com> (raw)
In-Reply-To: <20170218083556.20215-1-romain.perier@collabora.com>
On Sat, Feb 18, 2017 at 09:35:36AM +0100, Romain Perier wrote:
Tested all patches by compilation and checkpatch. All of them compile
fine, but patches 11 and 12 need some fixes. You can resend as
PATCH instead of RFC.
> The current PCI pool API are simple macro functions direct expanded to
> the appropriated dma pool functions. The prototypes are almost the same
> and semantically, they are very similar. I propose to use the DMA pool
> API directly and get rid of the old API.
>
> This set of patches, replaces the old API by the dma pool API, adds
> support to warn about this old API in checkpath.pl and remove the
> defines.
>
> Changes in v2:
> - Introduced patch 18/20
> - Fixed cosmetic changes: spaces before brace, live over 80 characters
> - Removed some of the check for NULL pointers before calling dma_pool_destroy
> - Improved the regexp in checkpatch for pci_pool, thanks to Joe Perches
> - Added Tested-by and Acked-by tags
>
> Romain Perier (20):
> block: DAC960: Replace PCI pool old API
> dmaengine: pch_dma: Replace PCI pool old API
> IB/mthca: Replace PCI pool old API
> net: e100: Replace PCI pool old API
> mlx4: Replace PCI pool old API
> mlx5: Replace PCI pool old API
> wireless: ipw2200: Replace PCI pool old API
> scsi: be2iscsi: Replace PCI pool old API
> scsi: csiostor: Replace PCI pool old API
> scsi: lpfc: Replace PCI pool old API
> scsi: megaraid: Replace PCI pool old API
> scsi: mpt3sas: Replace PCI pool old API
> scsi: mvsas: Replace PCI pool old API
> scsi: pmcraid: Replace PCI pool old API
> usb: gadget: amd5536udc: Replace PCI pool old API
> usb: gadget: net2280: Replace PCI pool old API
> usb: gadget: pch_udc: Replace PCI pool old API
> usb: host: Remove remaining pci_pool in comments
> PCI: Remove PCI pool macro functions
> checkpatch: warn for use of old PCI pool API
>
> drivers/block/DAC960.c | 36 ++++++-------
> drivers/block/DAC960.h | 4 +-
> drivers/dma/pch_dma.c | 12 ++---
> drivers/infiniband/hw/mthca/mthca_av.c | 10 ++--
> drivers/infiniband/hw/mthca/mthca_cmd.c | 8 +--
> drivers/infiniband/hw/mthca/mthca_dev.h | 4 +-
> drivers/net/ethernet/intel/e100.c | 12 ++---
> drivers/net/ethernet/mellanox/mlx4/cmd.c | 10 ++--
> drivers/net/ethernet/mellanox/mlx4/mlx4.h | 2 +-
> drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 11 ++--
> drivers/net/wireless/intel/ipw2x00/ipw2200.c | 13 ++---
> drivers/scsi/be2iscsi/be_iscsi.c | 6 +--
> drivers/scsi/be2iscsi/be_main.c | 6 +--
> drivers/scsi/be2iscsi/be_main.h | 2 +-
> drivers/scsi/csiostor/csio_hw.h | 2 +-
> drivers/scsi/csiostor/csio_init.c | 11 ++--
> drivers/scsi/csiostor/csio_scsi.c | 6 +--
> drivers/scsi/lpfc/lpfc.h | 10 ++--
> drivers/scsi/lpfc/lpfc_init.c | 6 +--
> drivers/scsi/lpfc/lpfc_mem.c | 73 +++++++++++++--------------
> drivers/scsi/lpfc/lpfc_scsi.c | 12 ++---
> drivers/scsi/megaraid/megaraid_mbox.c | 30 +++++------
> drivers/scsi/megaraid/megaraid_mm.c | 29 ++++++-----
> drivers/scsi/megaraid/megaraid_sas_base.c | 25 ++++-----
> drivers/scsi/megaraid/megaraid_sas_fusion.c | 51 ++++++++++---------
> drivers/scsi/mpt3sas/mpt3sas_base.c | 73 +++++++++++++--------------
> drivers/scsi/mvsas/mv_init.c | 6 +--
> drivers/scsi/mvsas/mv_sas.c | 6 +--
> drivers/scsi/pmcraid.c | 10 ++--
> drivers/scsi/pmcraid.h | 2 +-
> drivers/usb/gadget/udc/amd5536udc.c | 8 +--
> drivers/usb/gadget/udc/amd5536udc.h | 4 +-
> drivers/usb/gadget/udc/net2280.c | 12 ++---
> drivers/usb/gadget/udc/net2280.h | 2 +-
> drivers/usb/gadget/udc/pch_udc.c | 31 ++++++------
> drivers/usb/host/ehci-hcd.c | 2 +-
> drivers/usb/host/fotg210-hcd.c | 2 +-
> drivers/usb/host/oxu210hp-hcd.c | 2 +-
> include/linux/mlx5/driver.h | 2 +-
> include/linux/pci.h | 9 ----
> scripts/checkpatch.pl | 9 +++-
> 41 files changed, 284 insertions(+), 287 deletions(-)
>
> --
> 2.9.3
>
next prev parent reply other threads:[~2017-02-18 18:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170218083556.20215-1-romain.perier@collabora.com>
[not found] ` <20170218083556.20215-2-romain.perier@collabora.com>
2017-02-18 12:51 ` [RFC v2 01/20] block: DAC960: Replace PCI pool old API Peter Senna Tschudin
2017-02-18 13:06 ` [RFC v2 00/20] Replace PCI pool by DMA pool API Greg Kroah-Hartman
[not found] ` <20170218130600.GA24938-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-02-18 17:57 ` Romain Perier
[not found] ` <20170218083556.20215-13-romain.perier@collabora.com>
[not found] ` <20170218083556.20215-13-romain.perier-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2017-02-18 18:40 ` [RFC v2 12/20] scsi: mpt3sas: Replace PCI pool old API Peter Senna Tschudin
2017-02-18 18:46 ` Peter Senna Tschudin [this message]
[not found] ` <20170218083556.20215-12-romain.perier@collabora.com>
[not found] ` <20170218083556.20215-12-romain.perier-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2017-02-18 18:37 ` [RFC v2 11/20] scsi: megaraid: " Peter Senna Tschudin
2017-02-18 19:11 ` Peter Senna Tschudin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170218184659.GD13698@collabora.com \
--to=peter.senna@collabora.com \
--cc=balbi@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=dledford@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=hal.rosenstock@gmail.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=peter.senna@collabora.co.uk \
--cc=romain.perier@collabora.com \
--cc=sean.hefty@intel.com \
--cc=stas.yakovlev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).