From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [patch iproute2/net-next] devlink: use DEVLINK_CMD_ESWITCH_* instead of DEVLINK_CMD_ESWITCH_MODE_* Date: Sun, 19 Feb 2017 11:57:14 -0800 Message-ID: <20170219115714.7dbdde5a@xeon-e3> References: <1487515026-5826-1-git-send-email-jiri@resnulli.us> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, ogerlitz@mellanox.com, mlxsw@mellanox.com To: Jiri Pirko Return-path: Received: from mail-pg0-f48.google.com ([74.125.83.48]:33769 "EHLO mail-pg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751167AbdBST5S (ORCPT ); Sun, 19 Feb 2017 14:57:18 -0500 Received: by mail-pg0-f48.google.com with SMTP id a123so8119386pgc.0 for ; Sun, 19 Feb 2017 11:57:17 -0800 (PST) In-Reply-To: <1487515026-5826-1-git-send-email-jiri@resnulli.us> Sender: netdev-owner@vger.kernel.org List-ID: On Sun, 19 Feb 2017 15:37:06 +0100 Jiri Pirko wrote: > From: Jiri Pirko > > Sync with kernel and don't use the obsolete enum values. > > Signed-off-by: Jiri Pirko > --- > devlink/devlink.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/devlink/devlink.c b/devlink/devlink.c > index 34a409f..c357580 100644 > --- a/devlink/devlink.c > +++ b/devlink/devlink.c > @@ -1303,7 +1303,7 @@ static int cmd_dev_eswitch_show(struct dl *dl) > struct nlmsghdr *nlh; > int err; > > - nlh = mnlg_msg_prepare(dl->nlg, DEVLINK_CMD_ESWITCH_MODE_GET, > + nlh = mnlg_msg_prepare(dl->nlg, DEVLINK_CMD_ESWITCH_GET, > NLM_F_REQUEST | NLM_F_ACK); > > err = dl_argv_parse_put(nlh, dl, DL_OPT_HANDLE, 0); > @@ -1321,7 +1321,7 @@ static int cmd_dev_eswitch_set(struct dl *dl) > struct nlmsghdr *nlh; > int err; > > - nlh = mnlg_msg_prepare(dl->nlg, DEVLINK_CMD_ESWITCH_MODE_SET, > + nlh = mnlg_msg_prepare(dl->nlg, DEVLINK_CMD_ESWITCH_SET, > NLM_F_REQUEST | NLM_F_ACK); > > err = dl_argv_parse_put(nlh, dl, DL_OPT_HANDLE, I think you need go go back and reconsider the ABI change. This patch would cause the net-next version of iproute2 devlink to not work with older kernels. The iproute2 toolset relies on the kernel ABI guarantees so that later versions of iproute2 still interoperate with older kernels. It is possible that new features get added but the old functionality will always work.