From: Stephen Hemminger <stephen@networkplumber.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, ogerlitz@mellanox.com, mlxsw@mellanox.com
Subject: Re: [patch iproute2/net-next] devlink: use DEVLINK_CMD_ESWITCH_* instead of DEVLINK_CMD_ESWITCH_MODE_*
Date: Sun, 19 Feb 2017 12:01:15 -0800 [thread overview]
Message-ID: <20170219120115.391906ba@xeon-e3> (raw)
In-Reply-To: <1487515026-5826-1-git-send-email-jiri@resnulli.us>
On Sun, 19 Feb 2017 15:37:06 +0100
Jiri Pirko <jiri@resnulli.us> wrote:
> From: Jiri Pirko <jiri@mellanox.com>
>
> Sync with kernel and don't use the obsolete enum values.
>
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
> ---
> devlink/devlink.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/devlink/devlink.c b/devlink/devlink.c
> index 34a409f..c357580 100644
> --- a/devlink/devlink.c
> +++ b/devlink/devlink.c
> @@ -1303,7 +1303,7 @@ static int cmd_dev_eswitch_show(struct dl *dl)
> struct nlmsghdr *nlh;
> int err;
>
> - nlh = mnlg_msg_prepare(dl->nlg, DEVLINK_CMD_ESWITCH_MODE_GET,
> + nlh = mnlg_msg_prepare(dl->nlg, DEVLINK_CMD_ESWITCH_GET,
> NLM_F_REQUEST | NLM_F_ACK);
>
> err = dl_argv_parse_put(nlh, dl, DL_OPT_HANDLE, 0);
> @@ -1321,7 +1321,7 @@ static int cmd_dev_eswitch_set(struct dl *dl)
> struct nlmsghdr *nlh;
> int err;
>
> - nlh = mnlg_msg_prepare(dl->nlg, DEVLINK_CMD_ESWITCH_MODE_SET,
> + nlh = mnlg_msg_prepare(dl->nlg, DEVLINK_CMD_ESWITCH_SET,
> NLM_F_REQUEST | NLM_F_ACK);
>
> err = dl_argv_parse_put(nlh, dl, DL_OPT_HANDLE,
I went back and looked at the original commit.
devlink: fix the name of eswitch commands
OK, so you only changed the name, not the value so it would be binary
compatible.
Applied.
next prev parent reply other threads:[~2017-02-19 20:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-19 14:37 [patch iproute2/net-next] devlink: use DEVLINK_CMD_ESWITCH_* instead of DEVLINK_CMD_ESWITCH_MODE_* Jiri Pirko
2017-02-19 19:57 ` Stephen Hemminger
2017-02-19 20:01 ` Stephen Hemminger [this message]
2017-02-19 20:59 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170219120115.391906ba@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=jiri@resnulli.us \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox