From: David Miller <davem@davemloft.net>
To: sowmini.varadhan@oracle.com
Cc: santosh.shilimkar@oracle.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [net-next][PATCH] RDS: keep data type consistent in the user visible header
Date: Mon, 20 Feb 2017 10:39:12 -0500 (EST) [thread overview]
Message-ID: <20170220.103912.194197218422769191.davem@davemloft.net> (raw)
In-Reply-To: <20170220153722.GB16561@oracle.com>
From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
Date: Mon, 20 Feb 2017 10:37:22 -0500
> On (02/20/17 10:19), David Miller wrote:
>>
>> The correct fix it to use "__u8", "__u64", etc.
>
> So the rest of rds.h uses uint8_t, uint32_t etc
> Perhaps (I'm not sure of the origins) this was because
> of the shared OpenIB.org BSD license etc using __u8 in
> one place and uint8_t in another would seem inconsistent,
> at the very least.
The entire file should use the proper "__uX" kernel types
rather than the uint* ones.
next prev parent reply other threads:[~2017-02-20 15:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-18 3:15 [net-next][PATCH] RDS: keep data type consistent in the user visible header Santosh Shilimkar
2017-02-20 15:19 ` David Miller
2017-02-20 15:37 ` Sowmini Varadhan
2017-02-20 15:39 ` David Miller [this message]
2017-02-21 14:29 ` David Laight
2017-02-21 14:55 ` santosh.shilimkar
2017-02-21 14:58 ` Edward Cree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170220.103912.194197218422769191.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=santosh.shilimkar@oracle.com \
--cc=sowmini.varadhan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).