From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: Quentin Schulz <quentin.schulz@free-electrons.com>,
fvallee@eukrea.fr, wg@grandegger.com, mkl@pengutronix.de,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, boris.brezillon@free-electrons.com,
nicolas.ferre@atmel.com
Subject: Re: [RESEND PATCH 1/1] can: m_can: fix bitrate setup on latest silicon
Date: Mon, 20 Feb 2017 17:37:14 +0100 [thread overview]
Message-ID: <20170220163714.uj5el22c5tq47cul@piout.net> (raw)
In-Reply-To: <b1140be9-1811-1512-b32e-436e8bb25824@hartkopp.net>
On 19/02/2017 at 16:37:50 +0100, Oliver Hartkopp wrote:
> Fortunately I was contacted by Bosch this Friday as they want to contribute
> a driver upgrade to support IP cores up to 3.2.x.
> Additionally their plan is to use Device Tree information to determine the
> IP core revision - or at least to cross check its information with the
> register information used in your suggestion.
My opinion is that is is not really useful. Either we use the version
info from the register or DT. But that is probably a matter of taste and
you are the maintainer :)
> For that reason I would suggest to wait for the driver updates from Bosch
> instead of adding an incomplete fix for only one change of eleven.
>
Well, having something working right now is still better that nothing. I
think it is worth having that patch now so CAN is working on our
platforms.
Everything else can probably be built on top of it anyway.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-02-20 16:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-15 14:08 [RESEND PATCH 1/1] can: m_can: fix bitrate setup on latest silicon Quentin Schulz
2017-02-19 15:37 ` Oliver Hartkopp
2017-02-20 16:37 ` Alexandre Belloni [this message]
2017-02-20 16:44 ` Marc Kleine-Budde
2017-02-20 16:50 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170220163714.uj5el22c5tq47cul@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=boris.brezillon@free-electrons.com \
--cc=fvallee@eukrea.fr \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=quentin.schulz@free-electrons.com \
--cc=socketcan@hartkopp.net \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox