From: Andrew Lunn <andrew@lunn.ch>
To: YUAN Linyu <Linyu.Yuan@alcatel-sbell.com.cn>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"cugyly@163.com" <cugyly@163.com>
Subject: Re: create drivers/net/mdio and move mdio drivers into it
Date: Wed, 22 Feb 2017 11:21:09 +0100 [thread overview]
Message-ID: <20170222102109.GB18705@lunn.ch> (raw)
In-Reply-To: <8729016553E3654398EA69218DA29EEF15A81861@cnshjmbx02>
On Wed, Feb 22, 2017 at 05:38:49AM +0000, YUAN Linyu wrote:
> Hi Florian,
>
> 1.
> Let's go back to original topic,
> Can we move all mdio dirvers into drivers/net/mdio ?
Hi Yuan
Please could you explain what benefit this brings. Please also list
all the downsides for such a move. As Florian said, we need to ensure
such a move adds more value than it removes.
> Per may understanding,
> I don't know why create a struct mii_bus instance to represent a mdio device in current mdio driver.
> Why not create a struct mdio_device instance, it's easy to understand.
> (We can move part of member of mii_bus to mdio_device).
Please take a step back. What are you trying to achieve. What is the
big picture. What cannot you do with the current design?
Andrew
next prev parent reply other threads:[~2017-02-22 10:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-20 0:20 create drivers/net/mdio and move mdio drivers into it YUAN Linyu
2017-02-20 5:03 ` Florian Fainelli
2017-02-20 5:23 ` YUAN Linyu
2017-02-20 5:42 ` Florian Fainelli
2017-02-20 6:10 ` YUAN Linyu
2017-02-20 6:15 ` Florian Fainelli
2017-02-20 6:26 ` YUAN Linyu
2017-02-20 22:30 ` Florian Fainelli
2017-02-20 6:29 ` YUAN Linyu
2017-02-20 22:31 ` Florian Fainelli
2017-02-21 0:47 ` YUAN Linyu
2017-02-22 5:38 ` YUAN Linyu
2017-02-22 10:21 ` Andrew Lunn [this message]
2017-02-23 0:10 ` YUAN Linyu
2017-02-23 9:30 ` Andrew Lunn
2017-02-23 9:51 ` YUAN Linyu
2017-02-23 10:29 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170222102109.GB18705@lunn.ch \
--to=andrew@lunn.ch \
--cc=Linyu.Yuan@alcatel-sbell.com.cn \
--cc=cugyly@163.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).