From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: create drivers/net/mdio and move mdio drivers into it Date: Wed, 22 Feb 2017 11:21:09 +0100 Message-ID: <20170222102109.GB18705@lunn.ch> References: <8729016553E3654398EA69218DA29EEF15A7E753@cnshjmbx02> <8729016553E3654398EA69218DA29EEF15A807CA@cnshjmbx02> <8729016553E3654398EA69218DA29EEF15A80800@cnshjmbx02> <119144e3-d42e-e4dd-d95d-624e4816cbe3@gmail.com> <8729016553E3654398EA69218DA29EEF15A81861@cnshjmbx02> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Florian Fainelli , "David S . Miller" , "netdev@vger.kernel.org" , "cugyly@163.com" To: YUAN Linyu Return-path: Received: from vps0.lunn.ch ([178.209.37.122]:48563 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932084AbdBVKV2 (ORCPT ); Wed, 22 Feb 2017 05:21:28 -0500 Content-Disposition: inline In-Reply-To: <8729016553E3654398EA69218DA29EEF15A81861@cnshjmbx02> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, Feb 22, 2017 at 05:38:49AM +0000, YUAN Linyu wrote: > Hi Florian, > > 1. > Let's go back to original topic, > Can we move all mdio dirvers into drivers/net/mdio ? Hi Yuan Please could you explain what benefit this brings. Please also list all the downsides for such a move. As Florian said, we need to ensure such a move adds more value than it removes. > Per may understanding, > I don't know why create a struct mii_bus instance to represent a mdio device in current mdio driver. > Why not create a struct mdio_device instance, it's easy to understand. > (We can move part of member of mii_bus to mdio_device). Please take a step back. What are you trying to achieve. What is the big picture. What cannot you do with the current design? Andrew