netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Pirko <jiri@resnulli.us>
To: "Mahesh Bandewar (महेश बंडेवार)" <maheshb@google.com>
Cc: Mahesh Bandewar <mahesh@bandewar.net>,
	Jay Vosburgh <j.vosburgh@gmail.com>,
	Andy Gospodarek <andy@greyhouse.net>,
	Veaceslav Falico <vfalico@gmail.com>,
	Nikolay Aleksandrov <nikolay@redhat.com>,
	David Miller <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH next 0/4] bonding: winter cleanup
Date: Wed, 22 Feb 2017 21:26:25 +0100	[thread overview]
Message-ID: <20170222202625.GA1757@nanopsycho> (raw)
In-Reply-To: <CAF2d9ji69=q-u+80Hj1y45YSjN9Tq4M4OBvbjNEWShiayN8U2A@mail.gmail.com>

Wed, Feb 22, 2017 at 08:23:13PM CET, maheshb@google.com wrote:
>On Tue, Feb 21, 2017 at 11:58 PM, Jiri Pirko <jiri@resnulli.us> wrote:
>> Wed, Feb 22, 2017 at 02:08:16AM CET, mahesh@bandewar.net wrote:
>>>From: Mahesh Bandewar <maheshb@google.com>
>>>
>>>Few cleanup patches that I have accumulated over some time now.
>>>
>>>(a) First two patches are basically to move the work-queue initialization
>>>    from every ndo_open / bond_open operation to once at the beginning while
>>>    port creation. Work-queue initialization is an unnecessary operation
>>>    for every 'ifup' operation. However we have some mode-specific work-queues
>>>    and mode can change anytime after port creation. So the second patch is
>>>    to ensure the correct work-handler is called based on the mode.
>>>
>>>(b) Third patch is simple and straightforward that removes hard-coded value
>>>    that was added into the initial commit and replaces it with the default
>>>    value configured.
>>>
>>>(c) The final patch in the series removes the unimplemented "port-moved" state
>>>    from the LACP state machine. This state is defined but never set so
>>>    removing from the state machine logic makes code little cleaner.
>>>
>>>Note: None of these patches are making any functional changes.
>>>
>>>Mahesh Bandewar (4):
>>
>> Mahesh. I understand that you are still using bonding. What's stopping
>> you from using team instead?
>>
>Let me just say this, if it was trivial enough, we'd have done with it
>by now. :)

What exactly is the blocker? Can I help?

      reply	other threads:[~2017-02-22 20:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-22  1:08 [PATCH next 0/4] bonding: winter cleanup Mahesh Bandewar
2017-02-22  3:29 ` David Miller
2017-02-22  4:36   ` Or Gerlitz
2017-02-22 19:17     ` Mahesh Bandewar (महेश बंडेवार)
2017-02-22 19:21       ` Andy Gospodarek
2017-02-22  7:58 ` Jiri Pirko
2017-02-22 19:23   ` Mahesh Bandewar (महेश बंडेवार)
2017-02-22 20:26     ` Jiri Pirko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170222202625.GA1757@nanopsycho \
    --to=jiri@resnulli.us \
    --cc=andy@greyhouse.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=j.vosburgh@gmail.com \
    --cc=mahesh@bandewar.net \
    --cc=maheshb@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@redhat.com \
    --cc=vfalico@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).