* [patch net] lib: Remove string from parman config selection
@ 2017-02-23 9:57 Jiri Pirko
2017-02-23 10:08 ` Geert Uytterhoeven
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Jiri Pirko @ 2017-02-23 9:57 UTC (permalink / raw)
To: netdev; +Cc: davem, geert, mlxsw
From: Jiri Pirko <jiri@mellanox.com>
As reported by Geert, remove the string so the user does not see this
config option. The option is explicitly selected only as a dependency of
in-kernel users.
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Fixes: 44091d29f207 ("lib: Introduce priority array area manager")
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
---
lib/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/Kconfig b/lib/Kconfig
index 5d644f1..f355260 100644
--- a/lib/Kconfig
+++ b/lib/Kconfig
@@ -551,6 +551,6 @@ config SBITMAP
bool
config PARMAN
- tristate "parman"
+ tristate
endmenu
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [patch net] lib: Remove string from parman config selection 2017-02-23 9:57 [patch net] lib: Remove string from parman config selection Jiri Pirko @ 2017-02-23 10:08 ` Geert Uytterhoeven 2017-02-23 15:55 ` David Miller 2017-02-24 7:54 ` Geert Uytterhoeven 2 siblings, 0 replies; 6+ messages in thread From: Geert Uytterhoeven @ 2017-02-23 10:08 UTC (permalink / raw) To: Jiri Pirko; +Cc: netdev@vger.kernel.org, David S. Miller, mlxsw Hi Jiri, On Thu, Feb 23, 2017 at 10:57 AM, Jiri Pirko <jiri@resnulli.us> wrote: > From: Jiri Pirko <jiri@mellanox.com> > > As reported by Geert, remove the string so the user does not see this > config option. The option is explicitly selected only as a dependency of > in-kernel users. Thanks! > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> > Fixes: 44091d29f207 ("lib: Introduce priority array area manager") > Signed-off-by: Jiri Pirko <jiri@mellanox.com> Tested-by: Geert Uytterhoeven <geert@linux-m68k.org> Gr{oetje,eeting}s, Geert ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch net] lib: Remove string from parman config selection 2017-02-23 9:57 [patch net] lib: Remove string from parman config selection Jiri Pirko 2017-02-23 10:08 ` Geert Uytterhoeven @ 2017-02-23 15:55 ` David Miller 2017-02-24 7:54 ` Geert Uytterhoeven 2 siblings, 0 replies; 6+ messages in thread From: David Miller @ 2017-02-23 15:55 UTC (permalink / raw) To: jiri; +Cc: netdev, geert, mlxsw From: Jiri Pirko <jiri@resnulli.us> Date: Thu, 23 Feb 2017 10:57:45 +0100 > From: Jiri Pirko <jiri@mellanox.com> > > As reported by Geert, remove the string so the user does not see this > config option. The option is explicitly selected only as a dependency of > in-kernel users. > > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> > Fixes: 44091d29f207 ("lib: Introduce priority array area manager") > Signed-off-by: Jiri Pirko <jiri@mellanox.com> Applied. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch net] lib: Remove string from parman config selection 2017-02-23 9:57 [patch net] lib: Remove string from parman config selection Jiri Pirko 2017-02-23 10:08 ` Geert Uytterhoeven 2017-02-23 15:55 ` David Miller @ 2017-02-24 7:54 ` Geert Uytterhoeven 2017-02-24 8:25 ` Jiri Pirko 2 siblings, 1 reply; 6+ messages in thread From: Geert Uytterhoeven @ 2017-02-24 7:54 UTC (permalink / raw) To: Jiri Pirko; +Cc: netdev@vger.kernel.org, David S. Miller, mlxsw Hi Jiri, On Thu, Feb 23, 2017 at 10:57 AM, Jiri Pirko <jiri@resnulli.us> wrote: > From: Jiri Pirko <jiri@mellanox.com> > > As reported by Geert, remove the string so the user does not see this > config option. The option is explicitly selected only as a dependency of > in-kernel users. > > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> > Fixes: 44091d29f207 ("lib: Introduce priority array area manager") > Signed-off-by: Jiri Pirko <jiri@mellanox.com> > --- > lib/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/Kconfig b/lib/Kconfig > index 5d644f1..f355260 100644 > --- a/lib/Kconfig > +++ b/lib/Kconfig > @@ -551,6 +551,6 @@ config SBITMAP > bool > > config PARMAN > - tristate "parman" > + tristate Upon second thought tristate "parman" if COMPILE_TEST might be better, as it allows to enable and run the accompanying test without dependencies. Gr{oetje,eeting}s, Geert ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch net] lib: Remove string from parman config selection 2017-02-24 7:54 ` Geert Uytterhoeven @ 2017-02-24 8:25 ` Jiri Pirko 2017-02-24 8:30 ` Geert Uytterhoeven 0 siblings, 1 reply; 6+ messages in thread From: Jiri Pirko @ 2017-02-24 8:25 UTC (permalink / raw) To: Geert Uytterhoeven; +Cc: netdev@vger.kernel.org, David S. Miller, mlxsw Fri, Feb 24, 2017 at 08:54:04AM CET, geert@linux-m68k.org wrote: >Hi Jiri, > >On Thu, Feb 23, 2017 at 10:57 AM, Jiri Pirko <jiri@resnulli.us> wrote: >> From: Jiri Pirko <jiri@mellanox.com> >> >> As reported by Geert, remove the string so the user does not see this >> config option. The option is explicitly selected only as a dependency of >> in-kernel users. >> >> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> >> Fixes: 44091d29f207 ("lib: Introduce priority array area manager") >> Signed-off-by: Jiri Pirko <jiri@mellanox.com> >> --- >> lib/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/lib/Kconfig b/lib/Kconfig >> index 5d644f1..f355260 100644 >> --- a/lib/Kconfig >> +++ b/lib/Kconfig >> @@ -551,6 +551,6 @@ config SBITMAP >> bool >> >> config PARMAN >> - tristate "parman" >> + tristate > >Upon second thought > > tristate "parman" if COMPILE_TEST > >might be better, as it allows to enable and run the accompanying test without >dependencies. > >Gr{oetje,eeting}s, > > Geert Geert, could you please send this as a follow-up? Thanks. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch net] lib: Remove string from parman config selection 2017-02-24 8:25 ` Jiri Pirko @ 2017-02-24 8:30 ` Geert Uytterhoeven 0 siblings, 0 replies; 6+ messages in thread From: Geert Uytterhoeven @ 2017-02-24 8:30 UTC (permalink / raw) To: Jiri Pirko; +Cc: netdev@vger.kernel.org, David S. Miller, mlxsw Hi Jiri, On Fri, Feb 24, 2017 at 9:25 AM, Jiri Pirko <jiri@resnulli.us> wrote: > Fri, Feb 24, 2017 at 08:54:04AM CET, geert@linux-m68k.org wrote: >>On Thu, Feb 23, 2017 at 10:57 AM, Jiri Pirko <jiri@resnulli.us> wrote: >>> From: Jiri Pirko <jiri@mellanox.com> >>> >>> As reported by Geert, remove the string so the user does not see this >>> config option. The option is explicitly selected only as a dependency of >>> in-kernel users. >>> >>> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> >>> Fixes: 44091d29f207 ("lib: Introduce priority array area manager") >>> Signed-off-by: Jiri Pirko <jiri@mellanox.com> >>> --- >>> lib/Kconfig | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/lib/Kconfig b/lib/Kconfig >>> index 5d644f1..f355260 100644 >>> --- a/lib/Kconfig >>> +++ b/lib/Kconfig >>> @@ -551,6 +551,6 @@ config SBITMAP >>> bool >>> >>> config PARMAN >>> - tristate "parman" >>> + tristate >> >>Upon second thought >> >> tristate "parman" if COMPILE_TEST >> >>might be better, as it allows to enable and run the accompanying test without >>dependencies. > > Geert, could you please send this as a follow-up? Thanks. Sure, will do. Gr{oetje,eeting}s, Geert ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-02-24 8:58 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-02-23 9:57 [patch net] lib: Remove string from parman config selection Jiri Pirko 2017-02-23 10:08 ` Geert Uytterhoeven 2017-02-23 15:55 ` David Miller 2017-02-24 7:54 ` Geert Uytterhoeven 2017-02-24 8:25 ` Jiri Pirko 2017-02-24 8:30 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).