From: Jiri Benc <jbenc@redhat.com>
To: Brian Russell <brussell@brocade.com>
Cc: <netdev@vger.kernel.org>
Subject: Re: [PATCH net] vxlan: don't allow overwrite of config src addr
Date: Thu, 23 Feb 2017 17:03:29 +0100 [thread overview]
Message-ID: <20170223170329.1623bf53@griffin> (raw)
In-Reply-To: <1487611528-11468-1-git-send-email-brussell@brocade.com>
On Mon, 20 Feb 2017 17:25:28 +0000, Brian Russell wrote:
> When using IPv6 transport and a default dst, a pointer to the configured
> source address is passed into the route lookup. If no source address is
> configured, then the value is overwritten.
>
> IPv6 route lookup ignores egress ifindex match if the source adress is set,
> so if egress ifindex match is desired, the source address must be passed
> as any. The overwrite breaks this for subsequent lookups.
>
> Avoid this by copying the configured address to an existing stack variable
> and pass a pointer to that instead.
Seems there were another patches applied between the time you created
the patch and sent it and it doesn't apply.
Feel free to add to v2:
Acked-by: Jiri Benc <jbenc@redhat.com>
Jiri
next prev parent reply other threads:[~2017-02-23 16:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-20 17:25 [PATCH net] vxlan: don't allow overwrite of config src addr Brian Russell
2017-02-23 16:03 ` Jiri Benc [this message]
2017-02-23 16:10 ` Jiri Benc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170223170329.1623bf53@griffin \
--to=jbenc@redhat.com \
--cc=brussell@brocade.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).