* [PATCH net v2] vxlan: correctly validate VXLAN ID against VXLAN_N_VID
@ 2017-02-23 16:19 Matthias Schiffer
2017-02-23 16:26 ` Jiri Benc
2017-02-24 16:20 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Matthias Schiffer @ 2017-02-23 16:19 UTC (permalink / raw)
To: davem, jbenc; +Cc: netdev
The incorrect check caused an off-by-one error: the maximum VID 0xffffff
was unusable.
Fixes: d342894c5d2f ("vxlan: virtual extensible lan")
Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net>
---
v2: check against VXLAN_N_VID instead of changing operator
drivers/net/vxlan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index 556953f53437..268c2a12e61d 100644
--- a/drivers/net/vxlan.c
+++ b/drivers/net/vxlan.c
@@ -2675,7 +2675,7 @@ static int vxlan_validate(struct nlattr *tb[], struct nlattr *data[])
if (data[IFLA_VXLAN_ID]) {
__u32 id = nla_get_u32(data[IFLA_VXLAN_ID]);
- if (id >= VXLAN_VID_MASK)
+ if (id >= VXLAN_N_VID)
return -ERANGE;
}
--
2.11.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net v2] vxlan: correctly validate VXLAN ID against VXLAN_N_VID 2017-02-23 16:19 [PATCH net v2] vxlan: correctly validate VXLAN ID against VXLAN_N_VID Matthias Schiffer @ 2017-02-23 16:26 ` Jiri Benc 2017-02-24 16:20 ` David Miller 1 sibling, 0 replies; 3+ messages in thread From: Jiri Benc @ 2017-02-23 16:26 UTC (permalink / raw) To: Matthias Schiffer; +Cc: davem, netdev On Thu, 23 Feb 2017 17:19:41 +0100, Matthias Schiffer wrote: > The incorrect check caused an off-by-one error: the maximum VID 0xffffff > was unusable. > > Fixes: d342894c5d2f ("vxlan: virtual extensible lan") > Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net> > --- > v2: check against VXLAN_N_VID instead of changing operator Acked-by: Jiri Benc <jbenc@redhat.com> Thanks! Jiri ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net v2] vxlan: correctly validate VXLAN ID against VXLAN_N_VID 2017-02-23 16:19 [PATCH net v2] vxlan: correctly validate VXLAN ID against VXLAN_N_VID Matthias Schiffer 2017-02-23 16:26 ` Jiri Benc @ 2017-02-24 16:20 ` David Miller 1 sibling, 0 replies; 3+ messages in thread From: David Miller @ 2017-02-24 16:20 UTC (permalink / raw) To: mschiffer; +Cc: jbenc, netdev From: Matthias Schiffer <mschiffer@universe-factory.net> Date: Thu, 23 Feb 2017 17:19:41 +0100 > The incorrect check caused an off-by-one error: the maximum VID 0xffffff > was unusable. > > Fixes: d342894c5d2f ("vxlan: virtual extensible lan") > Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net> Applied and queued up for -stable, thanks. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-24 16:27 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-02-23 16:19 [PATCH net v2] vxlan: correctly validate VXLAN ID against VXLAN_N_VID Matthias Schiffer 2017-02-23 16:26 ` Jiri Benc 2017-02-24 16:20 ` David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).