From mboxrd@z Thu Jan 1 00:00:00 1970 From: Raju Lakkaraju Subject: Re: [PATCH v3 net-next] net: phy: Add LED mode driver for Microsemi PHYs. Date: Fri, 24 Feb 2017 11:35:17 +0530 Message-ID: <20170224060513.GA26086@microsemi.com> References: <1486474826-29426-1-git-send-email-Raju.Lakkaraju@microsemi.com> <20170215164540.eok7bnudfffzoyi4@rob-hp-laptop> <20170216090646.GA29082@microsemi.com> Reply-To: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: netdev , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Florian Fainelli , , Andrew Lunn To: Rob Herring Return-path: Content-Disposition: inline In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org Hi Rob, Thank you for code review comments. On Tue, Feb 21, 2017 at 10:42:38AM -0600, Rob Herring wrote: > EXTERNAL EMAIL > > > > Do i need to change from "vsc8531, led-0-mode" to "mscc, led-0-mode" > > Is this your suggestion? > > Well, there shouldn't be a space there, but yess, mscc is the prefix. > > Read my original comments. I also suggested combining this to a single property. > Accepted your comment. Fix the combining into single property and change prefix to mscc. I sent the latest code for review. Please review and send your comments. > Rob --- Thanks, Raju -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html