netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Pirko <jiri@resnulli.us>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	mlxsw@mellanox.com
Subject: Re: [patch net] lib: Remove string from parman config selection
Date: Fri, 24 Feb 2017 09:25:43 +0100	[thread overview]
Message-ID: <20170224082543.GA2357@nanopsycho> (raw)
In-Reply-To: <CAMuHMdWTm8Z8kuC6oBQFvpq2R289n5zG1wKOxQmMrUdC-OQ-6Q@mail.gmail.com>

Fri, Feb 24, 2017 at 08:54:04AM CET, geert@linux-m68k.org wrote:
>Hi Jiri,
>
>On Thu, Feb 23, 2017 at 10:57 AM, Jiri Pirko <jiri@resnulli.us> wrote:
>> From: Jiri Pirko <jiri@mellanox.com>
>>
>> As reported by Geert, remove the string so the user does not see this
>> config option. The option is explicitly selected only as a dependency of
>> in-kernel users.
>>
>> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
>> Fixes: 44091d29f207 ("lib: Introduce priority array area manager")
>> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
>> ---
>>  lib/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/Kconfig b/lib/Kconfig
>> index 5d644f1..f355260 100644
>> --- a/lib/Kconfig
>> +++ b/lib/Kconfig
>> @@ -551,6 +551,6 @@ config SBITMAP
>>         bool
>>
>>  config PARMAN
>> -       tristate "parman"
>> +       tristate
>
>Upon second thought
>
>        tristate "parman" if COMPILE_TEST
>
>might be better, as it allows to enable and run the accompanying test without
>dependencies.
>
>Gr{oetje,eeting}s,
>
>                        Geert


Geert, could you please send this as a follow-up? Thanks.

  reply	other threads:[~2017-02-24  8:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-23  9:57 [patch net] lib: Remove string from parman config selection Jiri Pirko
2017-02-23 10:08 ` Geert Uytterhoeven
2017-02-23 15:55 ` David Miller
2017-02-24  7:54 ` Geert Uytterhoeven
2017-02-24  8:25   ` Jiri Pirko [this message]
2017-02-24  8:30     ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170224082543.GA2357@nanopsycho \
    --to=jiri@resnulli.us \
    --cc=davem@davemloft.net \
    --cc=geert@linux-m68k.org \
    --cc=mlxsw@mellanox.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).