From: Stephen Hemminger <stephen@networkplumber.org>
To: Petr Vorel <pvorel@suse.cz>
Cc: netdev@vger.kernel.org, Mathias Nyman <m.nyman@iki.fi>,
Yegor Yefremov <yegorslists@googlemail.com>
Subject: Re: [PATCH 1/1] color: use "light" colors for dark background
Date: Fri, 24 Feb 2017 10:29:26 -0800 [thread overview]
Message-ID: <20170224102926.102b858f@xeon-e3> (raw)
In-Reply-To: <20170224101312.31538-1-pvorel@suse.cz>
On Fri, 24 Feb 2017 11:13:12 +0100
Petr Vorel <pvorel@suse.cz> wrote:
> COLORFGBG environment variable is used to detect dark background.
>
> Idea and a bit of code is borrowed from Vim, thanks.
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> Colors are nice, but the ones chosen aren't suitable for dark background.
> COLORFGBG environment variable is used in some libraries and software (e.g.
> ncurses, Vim). COLORFGBG is set by various terminal emulators (e.g. konsole,
> rxvt and rxvt-unicode).
>
> Chosen colors are questionable. Best solution would be also allow user to
> redefine colors, like ls does with LS_COLORS or grep with GREP_COLORS. But that
> is maybe overkill.
This really needs to be standardized with some convention. So that ls, grep, git
all behave the same and done by some standard library.
The current method is hack that keeps on growing.
next prev parent reply other threads:[~2017-02-24 18:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-24 10:13 [PATCH 1/1] color: use "light" colors for dark background Petr Vorel
2017-02-24 15:28 ` David Miller
2017-02-24 16:11 ` Johannes Berg
2017-02-24 16:22 ` David Miller
2017-02-24 16:50 ` Stephen Hemminger
2017-02-24 18:29 ` Stephen Hemminger [this message]
2017-02-27 7:55 ` Petr Vorel
2017-02-25 17:29 ` Mathias Nyman
2017-02-27 8:57 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170224102926.102b858f@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=m.nyman@iki.fi \
--cc=netdev@vger.kernel.org \
--cc=pvorel@suse.cz \
--cc=yegorslists@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).