netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: linux-bluetooth@vger.kernel.org
Cc: patrik.flykt@linux.intel.com, jukka.rissanen@linux.intel.com,
	stefan@osg.samsung.com, aar@pengutronix.de,
	linux-wpan@vger.kernel.org, netdev@vger.kernel.org
Subject: [PATCH v5 1/6] bluetooth: Set 6 byte device addresses
Date: Fri, 24 Feb 2017 14:14:35 +0200	[thread overview]
Message-ID: <20170224121440.32269-2-luiz.dentz@gmail.com> (raw)
In-Reply-To: <20170224121440.32269-1-luiz.dentz@gmail.com>

From: Patrik Flykt <patrik.flykt@linux.intel.com>

Set BTLE MAC addresses that are 6 bytes long and not 8 bytes
that are used in other places with 6lowpan.

Signed-off-by: Patrik Flykt <patrik.flykt@linux.intel.com>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
---
 net/bluetooth/6lowpan.c | 19 ++++++++-----------
 1 file changed, 8 insertions(+), 11 deletions(-)

diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c
index 1904a93..1456b01 100644
--- a/net/bluetooth/6lowpan.c
+++ b/net/bluetooth/6lowpan.c
@@ -80,6 +80,8 @@ struct lowpan_btle_dev {
 	struct delayed_work notify_peers;
 };
 
+static void set_addr(u8 *eui, u8 *addr, u8 addr_type);
+
 static inline struct lowpan_btle_dev *
 lowpan_btle_dev(const struct net_device *netdev)
 {
@@ -272,9 +274,10 @@ static int give_skb_to_upper(struct sk_buff *skb, struct net_device *dev)
 static int iphc_decompress(struct sk_buff *skb, struct net_device *netdev,
 			   struct l2cap_chan *chan)
 {
-	const u8 *saddr, *daddr;
+	const u8 *saddr;
 	struct lowpan_btle_dev *dev;
 	struct lowpan_peer *peer;
+	unsigned char eui64_daddr[EUI64_ADDR_LEN];
 
 	dev = lowpan_btle_dev(netdev);
 
@@ -285,9 +288,9 @@ static int iphc_decompress(struct sk_buff *skb, struct net_device *netdev,
 		return -EINVAL;
 
 	saddr = peer->eui64_addr;
-	daddr = dev->netdev->dev_addr;
+	set_addr(&eui64_daddr[0], chan->src.b, chan->src_type);
 
-	return lowpan_header_decompress(skb, netdev, daddr, saddr);
+	return lowpan_header_decompress(skb, netdev, &eui64_daddr, saddr);
 }
 
 static int recv_pkt(struct sk_buff *skb, struct net_device *dev,
@@ -681,13 +684,6 @@ static void set_addr(u8 *eui, u8 *addr, u8 addr_type)
 	BT_DBG("type %d addr %*phC", addr_type, 8, eui);
 }
 
-static void set_dev_addr(struct net_device *netdev, bdaddr_t *addr,
-		         u8 addr_type)
-{
-	netdev->addr_assign_type = NET_ADDR_PERM;
-	set_addr(netdev->dev_addr, addr->b, addr_type);
-}
-
 static void ifup(struct net_device *netdev)
 {
 	int err;
@@ -803,7 +799,8 @@ static int setup_netdev(struct l2cap_chan *chan, struct lowpan_btle_dev **dev)
 	if (!netdev)
 		return -ENOMEM;
 
-	set_dev_addr(netdev, &chan->src, chan->src_type);
+	netdev->addr_assign_type = NET_ADDR_PERM;
+	baswap((void *)netdev->dev_addr, &chan->src);
 
 	netdev->netdev_ops = &netdev_ops;
 	SET_NETDEV_DEV(netdev, &chan->conn->hcon->hdev->dev);
-- 
2.9.3

  reply	other threads:[~2017-02-24 12:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-24 12:14 [PATCH v5 0/6] Bluetooth: 6LoWPAN: Fix lladdr length Luiz Augusto von Dentz
2017-02-24 12:14 ` Luiz Augusto von Dentz [this message]
2017-02-24 12:14 ` [PATCH v5 2/6] 6lowpan: Set MAC address length according to LOWPAN_LLTYPE Luiz Augusto von Dentz
     [not found] ` <20170224121440.32269-1-luiz.dentz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-02-24 12:14   ` [PATCH v5 3/6] 6lowpan: iphc: override l2 packet information Luiz Augusto von Dentz
2017-02-24 12:14   ` [PATCH v5 4/6] ipv6: addrconf: fix 48 bit 6lowpan autoconfiguration Luiz Augusto von Dentz
2017-02-26  6:38     ` Alexander Aring
2017-03-01 11:09       ` Luiz Augusto von Dentz
2017-02-24 12:14 ` [PATCH v5 5/6] 6lowpan: Use netdev addr_len to determine lladdr len Luiz Augusto von Dentz
     [not found]   ` <20170224121440.32269-6-luiz.dentz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-02-27  7:13     ` Alexander Aring
     [not found]       ` <39321f06-c013-1e8f-efd1-2e230659535b-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2017-02-27  7:24         ` Alexander Aring
2017-02-24 12:14 ` [PATCH v5 6/6] 6lowpan: Fix IID format for Bluetooth Luiz Augusto von Dentz
     [not found]   ` <20170224121440.32269-7-luiz.dentz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-02-24 14:00     ` Stefan Schmidt
2017-02-26  6:05     ` Alexander Aring
     [not found]       ` <afc9cb44-edb6-287b-ce1d-da1c0974b5fa-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2017-02-26  6:25         ` Alexander Aring
2017-02-28  9:13   ` Jukka Rissanen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170224121440.32269-2-luiz.dentz@gmail.com \
    --to=luiz.dentz@gmail.com \
    --cc=aar@pengutronix.de \
    --cc=jukka.rissanen@linux.intel.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-wpan@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=patrik.flykt@linux.intel.com \
    --cc=stefan@osg.samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).