* [PATCH] iproute2: tc: introduce build dependency on libnetlink
@ 2017-02-24 17:28 Jiri Kosina
2017-02-24 23:13 ` Stephen Hemminger
0 siblings, 1 reply; 2+ messages in thread
From: Jiri Kosina @ 2017-02-24 17:28 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: netdev
From: Jiri Kosina <jkosina@suse.cz>
Rebuilding libnetlink doesn't trigger rebuild of tc, which is wrong
(especially so for builds where libnetlink.a gets statically linked into
tc). Fix that by introducing an explicit dependency.
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---
tc/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tc/Makefile b/tc/Makefile
index 6dd984f0..3f7fc939 100644
--- a/tc/Makefile
+++ b/tc/Makefile
@@ -127,7 +127,7 @@ MODDESTDIR := $(DESTDIR)$(LIBDIR)/tc
all: tc $(TCSO)
-tc: $(TCOBJ) libtc.a
+tc: $(TCOBJ) $(LIBNETLINK) libtc.a
$(QUIET_LINK)$(CC) $^ $(LDFLAGS) $(LDLIBS) -o $@
libtc.a: $(TCLIB)
--
Jiri Kosina
SUSE Labs
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iproute2: tc: introduce build dependency on libnetlink
2017-02-24 17:28 [PATCH] iproute2: tc: introduce build dependency on libnetlink Jiri Kosina
@ 2017-02-24 23:13 ` Stephen Hemminger
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Hemminger @ 2017-02-24 23:13 UTC (permalink / raw)
To: Jiri Kosina; +Cc: netdev
On Fri, 24 Feb 2017 18:28:54 +0100 (CET)
Jiri Kosina <jikos@kernel.org> wrote:
> From: Jiri Kosina <jkosina@suse.cz>
>
> Rebuilding libnetlink doesn't trigger rebuild of tc, which is wrong
> (especially so for builds where libnetlink.a gets statically linked into
> tc). Fix that by introducing an explicit dependency.
>
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Makes sense, Applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-24 23:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-24 17:28 [PATCH] iproute2: tc: introduce build dependency on libnetlink Jiri Kosina
2017-02-24 23:13 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).