* [PATCH net] ipv4: mask tos for input route
@ 2017-02-26 15:14 Julian Anastasov
2017-02-26 16:05 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Julian Anastasov @ 2017-02-26 15:14 UTC (permalink / raw)
To: David Miller; +Cc: netdev, Shmulik Ladkani
Restore the lost masking of TOS in input route code to
allow ip rules to match it properly.
Problem [1] noticed by Shmulik Ladkani <shmulik.ladkani@gmail.com>
[1] http://marc.info/?t=137331755300040&r=1&w=2
Fixes: 89aef8921bfb ("ipv4: Delete routing cache.")
Signed-off-by: Julian Anastasov <ja@ssi.bg>
---
net/ipv4/route.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/ipv4/route.c b/net/ipv4/route.c
index 584ed66..8471dd1 100644
--- a/net/ipv4/route.c
+++ b/net/ipv4/route.c
@@ -2009,6 +2009,7 @@ int ip_route_input_noref(struct sk_buff *skb, __be32 daddr, __be32 saddr,
{
int res;
+ tos &= IPTOS_RT_MASK;
rcu_read_lock();
/* Multicast recognition logic is moved from route cache to here.
--
1.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] ipv4: mask tos for input route
2017-02-26 15:14 [PATCH net] ipv4: mask tos for input route Julian Anastasov
@ 2017-02-26 16:05 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-02-26 16:05 UTC (permalink / raw)
To: ja; +Cc: netdev, shmulik.ladkani
From: Julian Anastasov <ja@ssi.bg>
Date: Sun, 26 Feb 2017 17:14:35 +0200
> Restore the lost masking of TOS in input route code to
> allow ip rules to match it properly.
>
> Problem [1] noticed by Shmulik Ladkani <shmulik.ladkani@gmail.com>
>
> [1] http://marc.info/?t=137331755300040&r=1&w=2
>
> Fixes: 89aef8921bfb ("ipv4: Delete routing cache.")
> Signed-off-by: Julian Anastasov <ja@ssi.bg>
Our TOS handling in the routing code is certainly more subtle than it
needs to be.
Applied and queued up for -stable.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-26 16:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-26 15:14 [PATCH net] ipv4: mask tos for input route Julian Anastasov
2017-02-26 16:05 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).