netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: linux-nvme@lists.infradead.org, target-devel@vger.kernel.org,
	netdev@vger.kernel.org
Subject: Re: [PATCH v1 3/4] nvme-rdma: use inet_pton_with_scope helper
Date: Tue, 28 Feb 2017 08:35:48 -0800	[thread overview]
Message-ID: <20170228163548.GC26480@infradead.org> (raw)
In-Reply-To: <1488217164-9221-4-git-send-email-sagi@grimberg.me>

Could use a proper changelog.

Otherwise looks fine:

Reviewed-by: Christoph Hellwig <hch@lst.de>

  reply	other threads:[~2017-02-28 16:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-27 17:39 [PATCH v1 0/4] Introduce a new helper for parsing ipv[4|6]:port to socket address Sagi Grimberg
2017-02-27 17:39 ` [PATCH v1 1/4] net/utils: generic inet_pton_with_scope helper Sagi Grimberg
2017-02-28 16:33   ` Christoph Hellwig
2017-02-27 17:39 ` [PATCH v1 2/4] nvmet-rdma: use generic inet_pton_with_scope Sagi Grimberg
2017-02-28 16:35   ` Christoph Hellwig
2017-02-28 17:41     ` Sagi Grimberg
2017-02-27 17:39 ` [PATCH v1 3/4] nvme-rdma: use inet_pton_with_scope helper Sagi Grimberg
2017-02-28 16:35   ` Christoph Hellwig [this message]
2017-02-28 17:42     ` Sagi Grimberg
2017-02-27 17:39 ` [PATCH v1 4/4] iscsi-target: use generic inet_pton_with_scope Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170228163548.GC26480@infradead.org \
    --to=hch@infradead.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=netdev@vger.kernel.org \
    --cc=sagi@grimberg.me \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).