public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Jiri Pirko <jiri@resnulli.us>
To: Zaboj Campula <zaboj.campula@post.cz>
Cc: Stephen Hemminger <stephen@networkplumber.org>, netdev@vger.kernel.org
Subject: Re: [PATCH] iproute2: show network device dependency tree
Date: Tue, 28 Feb 2017 22:47:34 +0100	[thread overview]
Message-ID: <20170228214734.GE1982@nanopsycho> (raw)
In-Reply-To: <1488313163.2131.3.camel@post.cz>

Tue, Feb 28, 2017 at 09:19:23PM CET, zaboj.campula@post.cz wrote:
>On Mon, 2017-02-27 at 10:55 -0800, Stephen Hemminger wrote:
>> 
>> Another alternative format would be to make -tree a output modifier and ident (like ps tree options).
>> 
>> $ ip -t link
>> 1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN mode DEFAULT group default qlen 1
>>     link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
>> 8: bond0 <BROADCAST,MULTICAST> mtu 1500 qdisc pfifo_fast state DOWN mode DEFAULT group default qlen 1000
>>     link/ether 52:54:00:66:24:cd brd ff:ff:ff:ff:ff:ff 
>>     2: eth1: <BROADCAST,MULTICAST> mtu 1500 qdisc pfifo_fast master bond0 state DOWN mode DEFAULT group default qlen 1000
>>         link/ether 52:54:00:66:24:cd brd ff:ff:ff:ff:ff:ff
>
>OK, it looks better because the information is complete.
>
>I looked at several tree printing utilities and I like
>the lsblk format. But tabular format does not fit the ip-show
>well. I will try to indent the current ip-show output may be
>with fancy lines.

I don't really think that the output you provide has any value. As JiriB
wrote, it is really problematic to draw relationships between devices.
Let's take OVS as a very non-trivial example. Your patch aims to handle
only the very basic ones.

      reply	other threads:[~2017-02-28 21:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-25 16:59 [PATCH] iproute2: show network device dependency tree Zaboj Campula
2017-02-25 17:39 ` Jiri Pirko
2017-02-25 20:22   ` Zaboj Campula
2017-02-26  7:56     ` Jiri Pirko
2017-02-26 14:00       ` Zaboj Campula
2017-02-26 14:46         ` Jiri Pirko
2017-02-27 16:38           ` Jiri Benc
2017-02-28 20:07             ` Zaboj Campula
2017-03-01 10:22               ` Jiri Benc
2017-03-02 19:51                 ` Zaboj Campula
2017-02-27 17:26       ` Stephen Hemminger
2017-02-27 18:52 ` Stephen Hemminger
2017-02-27 18:55 ` Stephen Hemminger
2017-02-28 20:19   ` Zaboj Campula
2017-02-28 21:47     ` Jiri Pirko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170228214734.GE1982@nanopsycho \
    --to=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    --cc=zaboj.campula@post.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox