From: David Miller <davem@davemloft.net>
To: colin.king@canonical.com
Cc: robert.foss@collabora.com, grundler@google.com,
allan@asix.com.tw, vpalatin@chromium.org, jarod@redhat.com,
peter.chen@nxp.com, linux-usb@vger.kernel.org,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: usb: asix_devices: fix missing return code check on call to asix_write_medium_mode
Date: Wed, 01 Mar 2017 12:52:26 -0500 (EST) [thread overview]
Message-ID: <20170301.125226.289007568565020464.davem@davemloft.net> (raw)
In-Reply-To: <20170228115822.20485-1-colin.king@canonical.com>
From: Colin King <colin.king@canonical.com>
Date: Tue, 28 Feb 2017 11:58:22 +0000
> From: Colin Ian King <colin.king@canonical.com>
>
> The call to asix_write_medium_mode is not updating the return code ret
> and yet ret is being checked for an error. Fix this by assigning ret to
> the return code from the call asix_write_medium_mode.
>
> Detected by CoverityScan, CID#1357148 ("Logically Dead Code")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
prev parent reply other threads:[~2017-03-01 17:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 11:58 [PATCH] net: usb: asix_devices: fix missing return code check on call to asix_write_medium_mode Colin King
2017-03-01 17:52 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170301.125226.289007568565020464.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=allan@asix.com.tw \
--cc=colin.king@canonical.com \
--cc=grundler@google.com \
--cc=jarod@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peter.chen@nxp.com \
--cc=robert.foss@collabora.com \
--cc=vpalatin@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).